Add jsblocks #1297

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
7 participants
@astoilkov
Contributor

astoilkov commented May 14, 2015

jsblocks have been developed for the past couple of years. Two weeks ago it was released and collected more than 800 stars. You could take a look at some of the advantages of the project here. Some of the things include:

  • Performance
  • Debugging exprience
  • Server-side rendering

Test results:

TodoMVC - blocks
  When page is initially opened
    √ should focus on the todo input field
  No Todos
    √ should hide #main and #footer (109ms)
  New Todo
    √ should allow me to add todo items (459ms)
    √ should clear text input field when an item is added (288ms)
    √ should append new items to the bottom of the list (570ms)
    √ should trim text input (262ms)
    √ should show #main and #footer when items added (253ms)
  Mark all as completed
    √ should allow me to mark all items as completed (610ms)
    √ should allow me to clear the completion state of all items (687ms)
    √ complete all checkbox should update state when items are completed / cleared (739ms)
  Item
    √ should allow me to mark items as complete (575ms)
    √ should allow me to un-mark items as complete (585ms)
    √ should allow me to edit an item (942ms)
    √ should show the remove button on hover
  Editing
    √ should hide other controls when editing (672ms)
    √ should save edits on enter (867ms)
    √ should save edits on blur (942ms)
    √ should trim entered text (868ms)
    √ should remove the item if an empty text string was entered (800ms)
    √ should cancel edits on escape (939ms)
  Counter
    √ should display the current number of todo items (399ms)
  Clear completed button
    √ should display the correct text (571ms)
    √ should remove completed items when clicked (865ms)
    √ should be hidden when there are no items that are completed (615ms)
  Persistence
    √ should persist its data (854ms)
  Routing
    √ should allow me to display active items (633ms)
    √ should respect the back button (892ms)
    √ should allow me to display completed items (616ms)
    √ should allow me to display all items (776ms)
    √ should highlight the currently applied filter (678ms)


30 passing (3m)

@arthurvr arthurvr added the new app label May 14, 2015

@urrgur

This comment has been minimized.

Show comment
Hide comment

urrgur commented May 25, 2015

👎

@mauricio-frontend

This comment has been minimized.

Show comment
Hide comment
@mauricio-frontend

mauricio-frontend May 26, 2015

This is a good Idea to put this on TodoMVC, I test JSBlock and like of your performance.

This is a good Idea to put this on TodoMVC, I test JSBlock and like of your performance.

@arthurvr

View changes

examples/blocks/.editorconfig
+indent_size = 2
+
+[*.md]
+trim_trailing_whitespace = false

This comment has been minimized.

@arthurvr

arthurvr May 31, 2015

Member

Please remove this file. We have our own code styling rules and those are in the root directory :) Same thing for .gitattributes :)

@arthurvr

arthurvr May 31, 2015

Member

Please remove this file. We have our own code styling rules and those are in the root directory :) Same thing for .gitattributes :)

@arthurvr

View changes

examples/blocks/.gitignore
@@ -0,0 +1,3 @@
+# Folders
+.idea
+/node_modules

This comment has been minimized.

@arthurvr

arthurvr May 31, 2015

Member

Let's remove the comment and .idea. That should be in your global gitignore. Please build a gitignore to easily manage your dependencies as other examples.

@arthurvr

arthurvr May 31, 2015

Member

Let's remove the comment and .idea. That should be in your global gitignore. Please build a gitignore to easily manage your dependencies as other examples.

@arthurvr

View changes

examples/blocks/index.html
@@ -0,0 +1,58 @@
+<!doctype html>
+<html lang="en">

This comment has been minimized.

@arthurvr

arthurvr May 31, 2015

Member

misses a data-framework attribute such as the other examples.

@arthurvr

arthurvr May 31, 2015

Member

misses a data-framework attribute such as the other examples.

@arthurvr

View changes

examples/blocks/index.html
+ <meta charset="utf-8">
+ <meta name="viewport" content="width=device-width, initial-scale=1">
+ <title>jsblocks • TodoMVC</title>
+ <link rel="stylesheet" href="node_modules/todomvc-app-css/index.css">

This comment has been minimized.

@arthurvr

arthurvr May 31, 2015

Member

Also include todomvc-common :)

@arthurvr

arthurvr May 31, 2015

Member

Also include todomvc-common :)

@arthurvr

View changes

examples/blocks/package.json
+{
+ "name": "jsblocks-todomvc",
+ "version": "0.2.0",
+ "private": true,

This comment has been minimized.

@arthurvr

arthurvr May 31, 2015

Member

If you're package is private you don't need name and version.

@arthurvr

arthurvr May 31, 2015

Member

If you're package is private you don't need name and version.

@arthurvr

View changes

examples/blocks/readme.md
+# jsblocks • [TodoMVC](http://todomvc.com)
+
+From simple user interfaces to complex single-page applications using faster, server-side rendered and easy to learn framework
+

This comment has been minimized.

@arthurvr

arthurvr May 31, 2015

Member

Can we format this part of the readme as the other examples? (the quote on top and source + website)

@arthurvr

arthurvr May 31, 2015

Member

Can we format this part of the readme as the other examples? (the quote on top and source + website)

@arthurvr

View changes

examples/blocks/readme.md
+
+## Credit
+
+Created by [Antonio Stoilkov](http://your-website.com)

This comment has been minimized.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr May 31, 2015

Member
  • Please add this example to learn.json and to the home page.
  • should the folder be named blocks or jsblocks?
  • Please commit all dependencies as seen in other examples.

Can you also fix the JSHint errors?

Member

arthurvr commented May 31, 2015

  • Please add this example to learn.json and to the home page.
  • should the folder be named blocks or jsblocks?
  • Please commit all dependencies as seen in other examples.

Can you also fix the JSHint errors?

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov May 31, 2015

Contributor

No problem. I will fix everything. Can you just clarify what do you mean by adding the example to the home page? Which home page and where?

Contributor

astoilkov commented May 31, 2015

No problem. I will fix everything. Can you just clarify what do you mean by adding the example to the home page? Which home page and where?

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr May 31, 2015

Member

@astoilkov To the home page of the website, index.html. If you have any other questions don't hesitate to ask. Thanks for working on this!

Member

arthurvr commented May 31, 2015

@astoilkov To the home page of the website, index.html. If you have any other questions don't hesitate to ask. Thanks for working on this!

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 2, 2015

Contributor

I think I fixed all reported things. As for the name of the folder - I have removed js because the npm package is called blocks and it is obvious that is a JavaScript framework. However, if you suggest that it is better to add the js I will rename the folder to jsblocks.

Contributor

astoilkov commented Jun 2, 2015

I think I fixed all reported things. As for the name of the folder - I have removed js because the npm package is called blocks and it is obvious that is a JavaScript framework. However, if you suggest that it is better to add the js I will rename the folder to jsblocks.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 6, 2015

Member

I think I fixed all reported things. As for the name of the folder - I have removed js because the npm package is called blocks and it is obvious that is a JavaScript framework. However, if you suggest that it is better to add the js I will rename the folder to jsblocks.

Well, we're not talking about an extension here. What's the name of the framework? Blocks? Or jsblocks?

Member

arthurvr commented Jun 6, 2015

I think I fixed all reported things. As for the name of the folder - I have removed js because the npm package is called blocks and it is obvious that is a JavaScript framework. However, if you suggest that it is better to add the js I will rename the folder to jsblocks.

Well, we're not talking about an extension here. What's the name of the framework? Blocks? Or jsblocks?

@arthurvr

View changes

examples/blocks/.gitignore
+
+node_modules/todomvc-common/*
+!node_modules/todomvc-common/base.css
+!node_modules/todomvc-common/base.js

This comment has been minimized.

@arthurvr

arthurvr Jun 6, 2015

Member

This gitignore looks okay but you forgot to actually add the files too.

@arthurvr

arthurvr Jun 6, 2015

Member

This gitignore looks okay but you forgot to actually add the files too.

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 6, 2015

Contributor

It's jsblocks. However, in jsdelivr and DefinitelyTyped the folders are called blocks. So its your call. I can't decide.

Contributor

astoilkov commented Jun 6, 2015

It's jsblocks. However, in jsdelivr and DefinitelyTyped the folders are called blocks. So its your call. I can't decide.

@arthurvr

View changes

examples/blocks/index.html
@@ -0,0 +1,59 @@
+<!doctype html>
+<html lang="en" data-framework="jsblocks">

This comment has been minimized.

@arthurvr

arthurvr Jun 6, 2015

Member

this should be equal to the folder name

@arthurvr

arthurvr Jun 6, 2015

Member

this should be equal to the folder name

@arthurvr

View changes

learn.json
@@ -2286,6 +2286,43 @@
}]
}]
},
+ "blocks": {

This comment has been minimized.

@arthurvr

arthurvr Jun 6, 2015

Member

this should be the same as the folder name

@arthurvr

arthurvr Jun 6, 2015

Member

this should be the same as the folder name

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 6, 2015

Member

Looks like I'm able to add empty todos.

Member

arthurvr commented Jun 6, 2015

Looks like I'm able to add empty todos.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 6, 2015

Member

@astoilkov jsblocks, then.

Member

arthurvr commented Jun 6, 2015

@astoilkov jsblocks, then.

@arthurvr

View changes

examples/blocks/js/app.js
+ },
+
+ clearCompleted: function () {
+ this.removeAll(function (todo) {

This comment has been minimized.

@arthurvr

arthurvr Jun 6, 2015

Member

Might be just my feeling but removeAll is a confusing name if you only want to remove specific items.

@arthurvr

arthurvr Jun 6, 2015

Member

Might be just my feeling but removeAll is a confusing name if you only want to remove specific items.

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 6, 2015

Contributor

Ok. Fixed noted things. Thanks for being so patient. :)

Contributor

astoilkov commented Jun 6, 2015

Ok. Fixed noted things. Thanks for being so patient. :)

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Jun 6, 2015

Member

@astoilkov mind squashing down into a single commit please?

Member

samccone commented Jun 6, 2015

@astoilkov mind squashing down into a single commit please?

@samccone

View changes

examples/jsblocks/index.html
+ <link rel="stylesheet" href="node_modules/todomvc-app-css/index.css">
+ </head>
+ <body>
+ <section id="todoapp" data-query="view(Todos)" class="todoapp">

This comment has been minimized.

@samccone

samccone Jun 6, 2015

Member

Should we use the v2 app spec here (classes instead of IDs) ?

@samccone

samccone Jun 6, 2015

Member

Should we use the v2 app spec here (classes instead of IDs) ?

This comment has been minimized.

@astoilkov

astoilkov Jun 7, 2015

Contributor

I added the id because the tests were failing without it. I can remove them quickly if this is not a problem.

@astoilkov

astoilkov Jun 7, 2015

Contributor

I added the id because the tests were failing without it. I can remove them quickly if this is not a problem.

This comment has been minimized.

@arthurvr

arthurvr Jun 7, 2015

Member

You can remove the id's. We're going to update the test suite shortly.

@arthurvr

arthurvr Jun 7, 2015

Member

You can remove the id's. We're going to update the test suite shortly.

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 7, 2015

Contributor

@samccone When everything is perfect I will make it a single commit. Just one question. I will do it by creating a new pull request with the one commit is there any other way for making it only one commit?

Contributor

astoilkov commented Jun 7, 2015

@samccone When everything is perfect I will make it a single commit. Just one question. I will do it by creating a new pull request with the one commit is there any other way for making it only one commit?

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 7, 2015

Member

When everything is perfect I will make it a single commit. Just one question. I will do it by creating a new pull request with the one commit is there any other way for making it only one commit?

Just squash them using a rebase and then force push this branch. If you've got troubles with that I'm happy to squash stuff for you while merging :)

Member

arthurvr commented Jun 7, 2015

When everything is perfect I will make it a single commit. Just one question. I will do it by creating a new pull request with the one commit is there any other way for making it only one commit?

Just squash them using a rebase and then force push this branch. If you've got troubles with that I'm happy to squash stuff for you while merging :)

@arthurvr

View changes

index.html
@@ -278,6 +278,9 @@
<li class="routing">
<a href="examples/webrx/" data-source="http://webrxjs.org" data-content="WebRx is a Javascript MVVM-Framework that combines functional-reactive programming with declarative Data-Binding, Templating and Client-Side Routing. The framework is built on top of ReactiveX for Javascript (RxJs) which is a powerful set of libraries for processing and querying asynchronous data-streams that can originate from diverse sources such as Http-Requests, Input-Events, Timers and much more.">WebRx</a>
</li>
+ <li class="routing">
+ <a href="examples/blocks/" data-source="http://jsblocks.com" data-content="From simple user interfaces to complex single-page applications using faster, server-side rendered and easy to learn framework">jsblocks</a>

This comment has been minimized.

@arthurvr

arthurvr Jun 7, 2015

Member

This link is now broken ;)

@arthurvr

arthurvr Jun 7, 2015

Member

This link is now broken ;)

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 7, 2015

Member

Looks like I'm able to add empty todos.

This is only partially fixed. I'm still able to edit an existing one with only whitespace.

Member

arthurvr commented Jun 7, 2015

Looks like I'm able to add empty todos.

This is only partially fixed. I'm still able to edit an existing one with only whitespace.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 7, 2015

Member

Could you please add some comments to the code? Specifically to the parts which might confuse beginners. (#385)

Member

arthurvr commented Jun 7, 2015

Could you please add some comments to the code? Specifically to the parts which might confuse beginners. (#385)

@arthurvr

View changes

examples/jsblocks/js/app.js
+(function () {
+ /*global blocks */
+
+ 'use strict';

This comment has been minimized.

@arthurvr

arthurvr Jun 7, 2015

Member

I believe it would be more consistent (and IMHO more logical) if you did

/*global blocks */
(function () {
    'use strict';
@arthurvr

arthurvr Jun 7, 2015

Member

I believe it would be more consistent (and IMHO more logical) if you did

/*global blocks */
(function () {
    'use strict';
@arthurvr

View changes

examples/jsblocks/js/app.js
+
+ return mode === 'active' ? !completed :
+ mode === 'completed' ? completed :
+ true;

This comment has been minimized.

@arthurvr

arthurvr Jun 7, 2015

Member

This 3 lines seem like a bunch of ternary magic. Code is for humans, keep it as readable as possible :)

@arthurvr

arthurvr Jun 7, 2015

Member

This 3 lines seem like a bunch of ternary magic. Code is for humans, keep it as readable as possible :)

This comment has been minimized.

@astoilkov

astoilkov Jun 7, 2015

Contributor

Saw this from the angular example.

@astoilkov

astoilkov Jun 7, 2015

Contributor

Saw this from the angular example.

This comment has been minimized.

@arthurvr

arthurvr Jun 13, 2015

Member

I don't like it there too :p Is there a reason to not split it up into a proper if statement?

@arthurvr

arthurvr Jun 13, 2015

Member

I don't like it there too :p Is there a reason to not split it up into a proper if statement?

This comment has been minimized.

@astoilkov

astoilkov Jun 13, 2015

Contributor

For me it is a little bit more clear when having a ternary operator in such cases. There are a few cases like this that I support this kind of technique. However, I agree that for begginers this could be overwhelming and switched to if statements.

@astoilkov

astoilkov Jun 13, 2015

Contributor

For me it is a little bit more clear when having a ternary operator in such cases. There are a few cases like this that I support this kind of technique. However, I agree that for begginers this could be overwhelming and switched to if statements.

This comment has been minimized.

@arthurvr

arthurvr Jun 13, 2015

Member

However, I agree that for begginers this could be overwhelming and switched to if statements.

👍

@arthurvr

arthurvr Jun 13, 2015

Member

However, I agree that for begginers this could be overwhelming and switched to if statements.

👍

+- [Website](http://jsblocks.com)
+- [Documentation](http://jsblocks.com/learn)
+- [Download](http://jsblocks.com/download)
+- [GitHub Page](https://github.com/astoilkov/jsblocks)

This comment has been minimized.

@arthurvr

arthurvr Jun 7, 2015

Member

This seems like linking up an official page 4 times. Are there any interesting blog posts we can link up?

@arthurvr

arthurvr Jun 7, 2015

Member

This seems like linking up an official page 4 times. Are there any interesting blog posts we can link up?

This comment has been minimized.

@astoilkov

astoilkov Jun 7, 2015

Contributor

There is one interesting DailyJS post. I could add it.

@astoilkov

astoilkov Jun 7, 2015

Contributor

There is one interesting DailyJS post. I could add it.

This comment has been minimized.

@arthurvr

arthurvr Jun 7, 2015

Member

Yep, why not.

@arthurvr

arthurvr Jun 7, 2015

Member

Yep, why not.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 7, 2015

Member

This one starts to look realllly good @astoilkov! 👍

Member

arthurvr commented Jun 7, 2015

This one starts to look realllly good @astoilkov! 👍

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 7, 2015

Contributor

@arthurvr

Looks like I'm able to add empty todos.
This is only partially fixed. I'm still able to edit an existing one with only whitespace.

I was not able to replicate that. Can you provide steps to do it?

Contributor

astoilkov commented Jun 7, 2015

@arthurvr

Looks like I'm able to add empty todos.
This is only partially fixed. I'm still able to edit an existing one with only whitespace.

I was not able to replicate that. Can you provide steps to do it?

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 7, 2015

Member

I was not able to replicate that. Can you provide steps to do it?

If this helps:

  1. Go to the todo app in latest Chrome
  2. Clear all the todo's
  3. Enter two items
  4. Double click the first one to edit it
  5. Clear out everything in the textbox
  6. Add a bunch of whitespace (spaces)
  7. Click out of the textbox to make it lose focus
  8. You've got a todo item that only exists out of whitespace

This does not seem to happen every time I try it. Don't have much time ATM but will dig in. Following error in the console:

developer_tools_-http___localhost_3000_examples_jsblocks__and_jsblocks _todomvc

Member

arthurvr commented Jun 7, 2015

I was not able to replicate that. Can you provide steps to do it?

If this helps:

  1. Go to the todo app in latest Chrome
  2. Clear all the todo's
  3. Enter two items
  4. Double click the first one to edit it
  5. Clear out everything in the textbox
  6. Add a bunch of whitespace (spaces)
  7. Click out of the textbox to make it lose focus
  8. You've got a todo item that only exists out of whitespace

This does not seem to happen every time I try it. Don't have much time ATM but will dig in. Following error in the console:

developer_tools_-http___localhost_3000_examples_jsblocks__and_jsblocks _todomvc

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 8, 2015

Contributor

@arthurvr I tried that couple of times but was not able to replicate the problem.

I commented the code, removed the ids and added the article to the readme. You could take a look at the comments and say if they are good enough.

I would love to do the squashing for me. :)

Contributor

astoilkov commented Jun 8, 2015

@arthurvr I tried that couple of times but was not able to replicate the problem.

I commented the code, removed the ids and added the article to the readme. You could take a look at the comments and say if they are good enough.

I would love to do the squashing for me. :)

@arthurvr

View changes

learn.json
+ "homepage": "http://jsblocks.com",
+ "examples": [{
+ "name": "Example",
+ "url": "examples/blocks"

This comment has been minimized.

@arthurvr

arthurvr Jun 9, 2015

Member

jsblocks no?

@arthurvr

arthurvr Jun 9, 2015

Member

jsblocks no?

This comment has been minimized.

@astoilkov

astoilkov Jun 10, 2015

Contributor

jsblocks yes.

@astoilkov

astoilkov Jun 10, 2015

Contributor

jsblocks yes.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 13, 2015

Member

⭐️ This starts to look really good to me ⭐️ Anyone else who wants to take a look?

I tried that couple of times but was not able to replicate the problem.

It's strange. The tests (combined with #1330) doesn't seem to pass all time too but it's really rare so happy to move forward for the time being. There are many other examples that have this kind of issues.

Member

arthurvr commented Jun 13, 2015

⭐️ This starts to look really good to me ⭐️ Anyone else who wants to take a look?

I tried that couple of times but was not able to replicate the problem.

It's strange. The tests (combined with #1330) doesn't seem to pass all time too but it's really rare so happy to move forward for the time being. There are many other examples that have this kind of issues.

+ include = completed;
+ }
+
+ return include;

This comment has been minimized.

@arthurvr

arthurvr Jun 13, 2015

Member

Why is this variable really needed? Just return inside of the if-statements. Also you don't really need the else if if you return early.

@arthurvr

arthurvr Jun 13, 2015

Member

Why is this variable really needed? Just return inside of the if-statements. Also you don't really need the else if if you return early.

This comment has been minimized.

@astoilkov

astoilkov Jun 13, 2015

Contributor

I decided to do it this way because:

  1. Further code implementation often lead to problems when returning early because other stuff that you expect to be executed does not executed...in certain situations
  2. Wwo more return statements in this case will lead to bigger file size
  3. In order to be more readable than the previous code I decided to add a include variable which hints to what the actual method purpose is and what actually means the returning of true and false
@astoilkov

astoilkov Jun 13, 2015

Contributor

I decided to do it this way because:

  1. Further code implementation often lead to problems when returning early because other stuff that you expect to be executed does not executed...in certain situations
  2. Wwo more return statements in this case will lead to bigger file size
  3. In order to be more readable than the previous code I decided to add a include variable which hints to what the actual method purpose is and what actually means the returning of true and false
@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 14, 2015

Member

Thanks for your neat work on this. @tastejs/todomvc anyone else who wants to take a look at this?

Member

arthurvr commented Jun 14, 2015

Thanks for your neat work on this. @tastejs/todomvc anyone else who wants to take a look at this?

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 14, 2015

Contributor

Thanks for your help. The final result is awesome.

Contributor

astoilkov commented Jun 14, 2015

Thanks for your help. The final result is awesome.

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Jun 17, 2015

Member

On initial refresh I see a flash of raw templates, can we avoid this?

screen shot 2015-06-17 at 10 40 53 am


⚠️ Looks like this implementation has a few memory leaks, causing the retention of DOM nodes.

Steps to reproduce
  • start timeline profiler
    • add three todos
    • delete three todos
    • (repeat above 2 more times)
  • force GC
  • stop timeline profiler

screen shot 2015-06-17 at 10 44 04 am
screen shot 2015-06-17 at 10 43 33 am

Member

samccone commented Jun 17, 2015

On initial refresh I see a flash of raw templates, can we avoid this?

screen shot 2015-06-17 at 10 40 53 am


⚠️ Looks like this implementation has a few memory leaks, causing the retention of DOM nodes.

Steps to reproduce
  • start timeline profiler
    • add three todos
    • delete three todos
    • (repeat above 2 more times)
  • force GC
  • stop timeline profiler

screen shot 2015-06-17 at 10 44 04 am
screen shot 2015-06-17 at 10 43 33 am

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 20, 2015

Contributor

Yeah. I will make the implementation so it doesn't flicker. Regarding the memory leak I have found where the problem is. How we could proceed with this? I guess I should release a new version of the project containing the fix for the memory leak and then update the dependencies here.

Contributor

astoilkov commented Jun 20, 2015

Yeah. I will make the implementation so it doesn't flicker. Regarding the memory leak I have found where the problem is. How we could proceed with this? I guess I should release a new version of the project containing the fix for the memory leak and then update the dependencies here.

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Jun 20, 2015

Member

yes please @astoilkov, would love to see what the actual bug was here as well! Thanks for investigating

Member

samccone commented Jun 20, 2015

yes please @astoilkov, would love to see what the actual bug was here as well! Thanks for investigating

astoilkov added a commit to astoilkov/jsblocks that referenced this pull request Jun 23, 2015

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jun 23, 2015

Contributor

I have fixed the problem with this commit. I will test this a little more and will push a release so we could include the change in the example.

Contributor

astoilkov commented Jun 23, 2015

I have fixed the problem with this commit. I will test this a little more and will push a release so we could include the change in the example.

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Jun 24, 2015

Member

👍 thanks @astoilkov that is awesome to hear, just ping us when you are ready for another review

Member

samccone commented Jun 24, 2015

👍 thanks @astoilkov that is awesome to hear, just ping us when you are ready for another review

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 29, 2015

Member

This also needs a rebase to fix the merge conflict.

Member

arthurvr commented Jun 29, 2015

This also needs a rebase to fix the merge conflict.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jul 11, 2015

Member

ping @astoilkov, was you able to publish a release?

Member

arthurvr commented Jul 11, 2015

ping @astoilkov, was you able to publish a release?

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jul 11, 2015

Contributor

@arthurvr No. Sorry. I was on a holiday and returned yesterday. I am a little sick now but I will publish a release next week.

Contributor

astoilkov commented Jul 11, 2015

@arthurvr No. Sorry. I was on a holiday and returned yesterday. I am a little sick now but I will publish a release next week.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jul 11, 2015

Member

Thanks.

Member

arthurvr commented Jul 11, 2015

Thanks.

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jul 21, 2015

Contributor

Sorry for the delay. Here are the updates. :)

Contributor

astoilkov commented Jul 21, 2015

Sorry for the delay. Here are the updates. :)

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Jul 21, 2015

Member

@astoilkov looks like we need a rebase 😉

Member

samccone commented Jul 21, 2015

@astoilkov looks like we need a rebase 😉

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jul 21, 2015

Contributor

I am not expert on git. Is there any possibility someone else can do it? If no...can you explain me the required steps you want me to take.

Contributor

astoilkov commented Jul 21, 2015

I am not expert on git. Is there any possibility someone else can do it? If no...can you explain me the required steps you want me to take.

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Aug 21, 2015

Contributor

Thanks @sindresorhus . It's time I do this.

Contributor

astoilkov commented Aug 21, 2015

Thanks @sindresorhus . It's time I do this.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Aug 26, 2015

Member

ping :)

Member

arthurvr commented Aug 26, 2015

ping :)

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Aug 26, 2015

Contributor

Yep. I am in process of completing it. Hope will do this in the next days.

Contributor

astoilkov commented Aug 26, 2015

Yep. I am in process of completing it. Hope will do this in the next days.

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Aug 26, 2015

Member

awesome thanks @astoilkov

Member

samccone commented Aug 26, 2015

awesome thanks @astoilkov

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Sep 29, 2015

Member

Hey @astoilkov looks like you are still failing a few tests, have you had a moment to take a look?

Member

samccone commented Sep 29, 2015

Hey @astoilkov looks like you are still failing a few tests, have you had a moment to take a look?

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Sep 30, 2015

Contributor

Yes. I found the problem. I will try fixing it without pushing to the todomvc repository. I will write back once done.

Contributor

astoilkov commented Sep 30, 2015

Yes. I found the problem. I will try fixing it without pushing to the todomvc repository. I will write back once done.

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Sep 30, 2015

Member

great thanks a bunch @astoilkov

Member

samccone commented Sep 30, 2015

great thanks a bunch @astoilkov

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Oct 5, 2015

Contributor

Hi @samccone. The issue is fixed. However, I will need to bump up the jsblocks version. I will fix a few more issues, bump up the version and then update it here.

Contributor

astoilkov commented Oct 5, 2015

Hi @samccone. The issue is fixed. However, I will need to bump up the jsblocks version. I will fix a few more issues, bump up the version and then update it here.

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Oct 5, 2015

Member

ok thanks for keeping us in the loop @astoilkov !!!

Member

samccone commented Oct 5, 2015

ok thanks for keeping us in the loop @astoilkov !!!

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Oct 12, 2015

Member

Hey @astoilkov any word :)

Member

samccone commented Oct 12, 2015

Hey @astoilkov any word :)

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Oct 12, 2015

Contributor

Yes. As I said I will release this week. Today we did the last bug fix that we wanted to include in the release. I will spend some time these days to make the release.

Contributor

astoilkov commented Oct 12, 2015

Yes. As I said I will release this week. Today we did the last bug fix that we wanted to include in the release. I will spend some time these days to make the release.

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Oct 12, 2015

Member

awesome

Just doing my weekly review of open PRs :) :)

Member

samccone commented Oct 12, 2015

awesome

Just doing my weekly review of open PRs :) :)

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Oct 13, 2015

Contributor

Ok. I am ready with the release. Now the only thing I should do is update the pull request adding the latest jsblocks version. I have a few questions though:

  • I would probably need to rebase again right? This is extremely hard for me so I ask an external person for this to help me so it could take some time.
  • I think after the last rebase we have wiped out some of the changes in the index.html and the jsblocks framework isn't there. Can you confirm that? If this is true I should add it again right?
Contributor

astoilkov commented Oct 13, 2015

Ok. I am ready with the release. Now the only thing I should do is update the pull request adding the latest jsblocks version. I have a few questions though:

  • I would probably need to rebase again right? This is extremely hard for me so I ask an external person for this to help me so it could take some time.
  • I think after the last rebase we have wiped out some of the changes in the index.html and the jsblocks framework isn't there. Can you confirm that? If this is true I should add it again right?
@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Oct 13, 2015

Member

would probably need to rebase again right? This is extremely hard for me so I ask an external person for this to help me so it could take some time.

Yep, you will want to rebase, however there are no conflicts so it should be as simple as git fetch <remote name>

git rebase <remote name> master

then git push -f

If this is true I should add it again right?

Yep add it back in :)

Member

samccone commented Oct 13, 2015

would probably need to rebase again right? This is extremely hard for me so I ask an external person for this to help me so it could take some time.

Yep, you will want to rebase, however there are no conflicts so it should be as simple as git fetch <remote name>

git rebase <remote name> master

then git push -f

If this is true I should add it again right?

Yep add it back in :)

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Oct 16, 2015

Member

Hey guys, I am going to close the PR, just ping us when you push and think it is good to go. Thanks

Member

samccone commented Oct 16, 2015

Hey guys, I am going to close the PR, just ping us when you push and think it is good to go. Thanks

@samccone samccone closed this Oct 16, 2015

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Oct 16, 2015

Contributor

👍

Contributor

astoilkov commented Oct 16, 2015

👍

@Kanaye

This comment has been minimized.

Show comment
Hide comment
@Kanaye

Kanaye Oct 16, 2015

Hey guys. We just updated the Repo and think we are ready to go 😄.

[edit]:
Sorry seems I derped with squashing the repo while in a closed PR. Didn't know that behaviour of github.
Can you do something about that or do we have to open a new one.
/cc @samccone @arthurvr

Kanaye commented Oct 16, 2015

Hey guys. We just updated the Repo and think we are ready to go 😄.

[edit]:
Sorry seems I derped with squashing the repo while in a closed PR. Didn't know that behaviour of github.
Can you do something about that or do we have to open a new one.
/cc @samccone @arthurvr

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Oct 17, 2015

Member

oh looks like it freaked out :( @Kanaye mind just opening a new one and linking it? Thanks!

Member

samccone commented Oct 17, 2015

oh looks like it freaked out :( @Kanaye mind just opening a new one and linking it? Thanks!

@Kanaye Kanaye referenced this pull request Oct 17, 2015

Merged

Add jsblocks #1477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment