New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update (Atma.js) rewrite the app #1337
Conversation
Thanks for doing this! |
2. Hint: Viewing *.mask files enable javascript or less syntax highlighting in your IDE | ||
1. Read the readme.md - you will get basic information about the libraries | ||
2. Hint: Use Sublime/Atom plugins to highlight the *.mask syntax | ||
, view them on github or enable Javascript/Less syntax for the extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The positioning of this comma looks a little weird. Let's just keep comments as we'd write all-day sentences.
Hey Arthur, thanks for the feedback, and sorry, my bad - unit tests have run upon the PR, but the Cheers,
|
--> | ||
|
||
<script type="text/mask" data-run="auto" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there's a space too much before >
.
3bee849
to
1e16329
Compare
@arthurvr, thank you for your comments. The style errors are gone, but it seems, |
1. Read readme.md - you will get basic information about the libraries | ||
2. Hint: Viewing *.mask files enable javascript or less syntax highlighting in your IDE | ||
1. Read the readme.md - you will get basic information about the libraries | ||
2. Hint: Use Sublime/Atom plugins to highlight the *.mask syntax, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Sublime/Atom plugins to highlight the *.mask syntax,
Seems like more somthing for the readme than for comments here. In fact I think this whole comment block would fit better in the readme.
@tenbits you shouldn't care about the CI for now. Just run the tests locally for the time being. I just ran them locally and seems like everything passes 🍰
Seems like there are still some missing newlines. |
"todomvc-app-css": "^1.0.0" | ||
"maskjs": "^0.51.26", | ||
"ruta": "^0.1.16", | ||
"todomvc-app-css": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we're rewriting anyways, mind switching to 2.0? You'll need to update from ids to classes. It will make all tests fail but don't worry, we're on it. Thanks!
Any community member(s) that want to review this? We want to make sure it follows best practices but I'm not the right one to review the code myself. |
Arthur, now the application uses |
Should this example now move to the compile-to-js section? |
@@ -109,10 +116,9 @@ navigate to ``` http://localhost:5777/ ``` | |||
|
|||
### Build | |||
|
|||
To build the application for release, run ``` $ atma build --file index.html --output release/```. We provide also a compiled version in 'build/' directory, so you | |||
can see how the application looks like for production. | |||
To build the application for release, run ``` $ atma build --file index.html --output release/```. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a single backtick for inline code.
Thanks for your hard work on this! |
I wouldn't do this, as
Done
And I take off my hat to you. |
@tastejs/todomvc Anyone of us who wants to take an extra look? If not I'm going to merge this one shortly. |
The one thing regarding the detached nodes, which dont let me sleep :) : Then I manually create one more todo and see the 7 detached nodes to disappear. Something strange happens somewhere ) I'll look later in details. |
Caught them) Shortly sad: a BinderFactory (Singleton) holds the last binded TextNode. And this TextNode was the part of the detached tree, so after removal of the last Todo, BinderFactory still holds the reference, but after we create a new Todo, the reference is replaced with the new one, and GC now collects the detached DOM tree. There is a little bit complicated binding process, as the rendering should work also in Node.js with further bootstrapping on the client. Anyway, a patch was applied to the binder library, and now you shouldn't see those detached nodes. Sam, once again, a HUGE thanks to you for pointing me at this!! |
|
||
— is not only an url routing via History API or ```hashchange```, but it implements a Route-Value Collection for adding/retrieving any object by the route. | ||
|
||
#### Atma.Toolkit | ||
[github](https://github.com/atmajs/Atma.Toolkit) | ||
[GitHub](https://github.com/atmajs/Atma.Toolkit) | ||
|
||
— command-line tool, which runs unit tests, builds applications, runs node.js ```bash``` scripts, creates static file server with live reload feature, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js (capital N). Also only use one backtick for bash
.
Thanks, Arthur, for helping me with this! |
Thank you! |
Can you rebase this branch upon master and run the tests? We recently updated our test suite to work with todomvc-app-css 2.0 😸 |
74483d8
to
de84dea
Compare
✔️ rebased |
Thanks! Looks like tests pass 🎉 |
going to do one pass of leaky on this then ⛵ |
}); | ||
}; | ||
|
||
}()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
})();
for consistency with the app template.
oh :( Looks like we still have a pretty significant leak of listeners
|
Yeap, Sam, after the leaky test run I can confirm the same behaviour 😞 Before last rebase I have removed the jquery dependency, seems something went wrong here. I'll dig into this. |
ok, thanks so much for your persistence on this front 👏 |
Sam, may I ask, what Chrome version are you testing upon?
|
i was testing this on 43, but let me run it against canary |
It seems, this is the same issue as before with |
Thanks Arthur, I have applied the changes. |
Just ran my latest memory profile iteration over this change set and it looks like we are good to go! |
update (Atma.js) rewrite the app
Hello Team,
updating here the Atma.js example with latest dependencies and features.
Thank you,
Alex