New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emberjs example versions #1343

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@passy

This comment has been minimized.

Show comment
Hide comment
@passy

passy Jun 16, 2015

Member

Are those just patch release updates to what's specified in the package.json, ie. what you get from running npm update?

Member

passy commented Jun 16, 2015

Are those just patch release updates to what's specified in the package.json, ie. what you get from running npm update?

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 16, 2015

@passy yeah I would do npm update, the thing is the issue is with ember-data, we would need to override that one. Do you want me to run npm update and override ember-data.js?

@passy yeah I would do npm update, the thing is the issue is with ember-data, we would need to override that one. Do you want me to run npm update and override ember-data.js?

npm update on emberjs example & update ember-data
This avoids an infinite PUTs loop when using RESTAdapter
ht @san650
@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 16, 2015

I've updated the PR reflecting exactly that. Now it's the result of npm update + curl http://builds.emberjs.com/beta/ember-data.js > node_modules/ember-data/ember-data.js

I've updated the PR reflecting exactly that. Now it's the result of npm update + curl http://builds.emberjs.com/beta/ember-data.js > node_modules/ember-data/ember-data.js

@passy

This comment has been minimized.

Show comment
Hide comment
@passy

passy Jun 17, 2015

Member

I'd like to get input from the others, but I'm slightly hesitant to including dependencies that aren't published on npm yet.

Member

passy commented Jun 17, 2015

I'd like to get input from the others, but I'm slightly hesitant to including dependencies that aren't published on npm yet.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 17, 2015

Member

I'd like to get input from the others, but I'm slightly hesitant to including dependencies that aren't published on npm yet.

Yep, we should try to push them to publishing it instead.

Member

arthurvr commented Jun 17, 2015

I'd like to get input from the others, but I'm slightly hesitant to including dependencies that aren't published on npm yet.

Yep, we should try to push them to publishing it instead.

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 17, 2015

I mainly updated ember-data because it's there anyway, and the one there has bugs.
But as you guys wish.

I mainly updated ember-data because it's there anyway, and the one there has bugs.
But as you guys wish.

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 24, 2015

A bit more context ember-data was added here 26d239c before it was being installed using bower.

/cc @tomdale @wycats

A bit more context ember-data was added here 26d239c before it was being installed using bower.

/cc @tomdale @wycats

@tomdale

This comment has been minimized.

Show comment
Hide comment
@tomdale

tomdale Jun 24, 2015

Contributor

We have plans to distribute Ember Data on npm but for now the official distribution channel is Bower. I'll reiterate that I think the best way to give people a taste of Ember is to use Ember CLI to build the app (#1069 (comment)); the whole point of Ember is that it's a complete front-end stack and abstracts away painful dependency management stuff like this.

Contributor

tomdale commented Jun 24, 2015

We have plans to distribute Ember Data on npm but for now the official distribution channel is Bower. I'll reiterate that I think the best way to give people a taste of Ember is to use Ember CLI to build the app (#1069 (comment)); the whole point of Ember is that it's a complete front-end stack and abstracts away painful dependency management stuff like this.

@wycats

This comment has been minimized.

Show comment
Hide comment

wycats commented Jun 24, 2015

I agree with @tomdale

@passy

This comment has been minimized.

Show comment
Hide comment
@passy

passy Jun 25, 2015

Member

I'd be in favor of migrating the example to ember-cli if it represents the
best practices for Ember development. Comparability isn't really meaningful
if the app would not actually be built that way.

What do the others think?

On Wed, Jun 24, 2015, 20:32 Yehuda Katz notifications@github.com wrote:

I agree with @tomdale https://github.com/tomdale


Reply to this email directly or view it on GitHub
#1343 (comment).

Member

passy commented Jun 25, 2015

I'd be in favor of migrating the example to ember-cli if it represents the
best practices for Ember development. Comparability isn't really meaningful
if the app would not actually be built that way.

What do the others think?

On Wed, Jun 24, 2015, 20:32 Yehuda Katz notifications@github.com wrote:

I agree with @tomdale https://github.com/tomdale


Reply to this email directly or view it on GitHub
#1343 (comment).

@addyosmani

This comment has been minimized.

Show comment
Hide comment
@addyosmani

addyosmani Jun 25, 2015

Member

I agree with @passy. If the idiomatic way to build all Ember apps is using ember-cli, then I'm in favour of us migrating the app in that direction.

Member

addyosmani commented Jun 25, 2015

I agree with @passy. If the idiomatic way to build all Ember apps is using ember-cli, then I'm in favour of us migrating the app in that direction.

@tomdale

This comment has been minimized.

Show comment
Hide comment
@tomdale

tomdale Jun 25, 2015

Contributor

@addyosmani That's awesome, do you want me to try to rustle up some community members to help out with this? I'm not sure where to get started.

Contributor

tomdale commented Jun 25, 2015

@addyosmani That's awesome, do you want me to try to rustle up some community members to help out with this? I'm not sure where to get started.

@addyosmani

This comment has been minimized.

Show comment
Hide comment
@addyosmani

addyosmani Jun 25, 2015

Member

@tomdale That would be incredibly helpful. One option would be to do a fresh implementation following our spec using ember-cli, using the current implementation of the Ember app for inspiration as needed. We can help with reviews/guidance for spec compliance. Love to see this through!

Member

addyosmani commented Jun 25, 2015

@tomdale That would be incredibly helpful. One option would be to do a fresh implementation following our spec using ember-cli, using the current implementation of the Ember app for inspiration as needed. We can help with reviews/guidance for spec compliance. Love to see this through!

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jun 26, 2015

Member

Over at #1069 some community members already showed their interest in building something up too.

Member

arthurvr commented Jun 26, 2015

Over at #1069 some community members already showed their interest in building something up too.

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 29, 2015

What about this repo https://github.com/ember-cli/ember-cli-todos and/or asking these people for help? /cc @tomdale @wycats

What about this repo https://github.com/ember-cli/ember-cli-todos and/or asking these people for help? /cc @tomdale @wycats

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Jul 2, 2015

Member

There was an Ember CLI example submitted: #1360. Let's close this PR in favor of that one.

Member

arthurvr commented Jul 2, 2015

There was an Ember CLI example submitted: #1360. Let's close this PR in favor of that one.

@arthurvr arthurvr closed this Jul 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment