New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Automated Leak Detection on CI ⚡️ #1464

Merged
merged 3 commits into from Oct 10, 2015

Conversation

Projects
None yet
4 participants
@samccone
Member

samccone commented Oct 9, 2015

With this PR Drool is now providing us with the ability to fail CI when an implementation has memory leaks.

The perf tests are now run on every PR 👾 🍝

  1. Add automated leak detection ⛲️
  2. Only run deploy code paths on deploy :) (faster test runs for everyone) 🐴
  3. Add some more compiled src ignores
@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Oct 9, 2015

Member

🍏 CI is working (angular2 fails because of no routing)

https://travis-ci.org/tastejs/todomvc/builds/84436464

Member

samccone commented Oct 9, 2015

🍏 CI is working (angular2 fails because of no routing)

https://travis-ci.org/tastejs/todomvc/builds/84436464

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Oct 9, 2015

Member

xref #1368

Member

samccone commented Oct 9, 2015

xref #1368

@ColinEberhardt

This comment has been minimized.

Show comment
Hide comment
@ColinEberhardt

ColinEberhardt Oct 9, 2015

Member

Wow, that is awesome! I'll definitely recommend using Drool to the developers where I work.

Member

ColinEberhardt commented Oct 9, 2015

Wow, that is awesome! I'll definitely recommend using Drool to the developers where I work.

@passy

This comment has been minimized.

Show comment
Hide comment
@passy

passy Oct 10, 2015

Member

I love this! Just tested this with a few apps and it's sooo good! Thanks for this, @samccone!

Member

passy commented Oct 10, 2015

I love this! Just tested this with a few apps and it's sooo good! Thanks for this, @samccone!

passy added a commit that referenced this pull request Oct 10, 2015

Merge pull request #1464 from tastejs/sjs/test-tweaks
⚡️ Automated Leak Detection on CI ⚡️

@passy passy merged commit 1365ef4 into master Oct 10, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@passy passy deleted the sjs/test-tweaks branch Oct 10, 2015

return f === framework.name;
});
});
}

This comment has been minimized.

@arthurvr

arthurvr Oct 10, 2015

Member

Missing semicolon, why didn't the linting process catch this?

@arthurvr

arthurvr Oct 10, 2015

Member

Missing semicolon, why didn't the linting process catch this?

This comment has been minimized.

@passy

passy Oct 10, 2015

Member

Or me! Outrageous! Fixed in master with 1567e60.

@passy

passy Oct 10, 2015

Member

Or me! Outrageous! Fixed in master with 1567e60.

This comment has been minimized.

@arthurvr

arthurvr Oct 10, 2015

Member

Thanks @passy! Still we should check what's wrong with the linting tooling though.

@arthurvr

arthurvr Oct 10, 2015

Member

Thanks @passy! Still we should check what's wrong with the linting tooling though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment