initial labs for epitome #235

Merged
merged 1 commit into from Jul 24, 2012

Projects

None yet

3 participants

Contributor

as per email, pull request for labs for Epitome for mootools.

standalone repo @ https://github.com/DimitarChristoff/Epitome-todo, which is also a submodule of Epitome for /example/todo

Owner

Thanks a lot for taking the time to put this together! Landing :)

@addyosmani addyosmani merged commit 90bb5cd into tastejs:master Jul 24, 2012
Owner

@DimitarChristoff Thanks :)

I looked at the app and found a few bugs I hope you can address:

  • Model attribute completed should be a boolean
  • When on a filter, e.g. Active and I check a todo item, the All filter is bolded even though it's not the current filter
  • Todo edits should be saved on blur and enter

Take not that I did a few cleanups to make it compatible with our style guide, so please pull before doing any changes.

Contributor

sure, should be trivial. will try to sort today

edit. wow @sindresorhus - i did not realise code style was enforced for this? being a mootools project, the code style was set to adhere to the framework code style as defined https://github.com/mootools/mootools-core/wiki/Syntax-and-Coding-Style-Conventions

anyway, your edits have totally botched indenting as well, a mix of tabs and spaces. tabs are preferred. for globals declarations, jshint now supports /*jshint mootools:true */ which automatically imports all globals - adding instead.

Contributor

done, see new pull request #239. the style changes alone have cost me an hour, I don't have the time to be doing this so if there's any further editing, please do so with caution else I won't be able to maintain it.

as for jslint/jshint flags etc and globals, Epitome works fine with require-js now so I can move the whole thing, if that's preferred. I just don't have the time right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment