Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Backbone remaining items counter does not update #370

Merged
merged 1 commit into from Jan 2, 2013

Conversation

Projects
None yet
2 participants
Member

passy commented Jan 2, 2013

This reverts the commit that caused it.

The end-to-end tests (#255) also pass with this patch applied. :)

Fix backbone remaining items counter
This reverts commit 9d4b0b0.

The simplified function call changes the semantics of it. The signature of
without is: _.without(array, [*values]), which is why apply must be used here.

sindresorhus added a commit that referenced this pull request Jan 2, 2013

Merge pull request #370 from passy/backbone-remaining-fix
Backbone remaining items counter does not update. Reverts 9d4b0b0

@sindresorhus sindresorhus merged commit 4a811d5 into tastejs:gh-pages Jan 2, 2013

Owner

sindresorhus commented Jan 2, 2013

This is a good example of why we need end-to-end testing. Thanks for the fix :)

gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this pull request Dec 23, 2013

Merge pull request #370 from passy/backbone-remaining-fix
Backbone remaining items counter does not update. Reverts 9d4b0b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment