Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Thorax: Removed on-ready initializtions #471

Merged
merged 1 commit into from

2 participants

@passy
Owner

During my style-cleanup I noticed some on-ready calls for parts of the Thorax app that seemed questionable to me. Is there any reason why those should be there?

/ping @eastridge

@eastridge

If it still works without the on ready calls I'm ok with this. Don't remember exactly which means it could have been a cargo-cult thing.

@passy
Owner

it could have been a cargo-cult thing.

I've been there, too. :)

@passy passy merged commit ed62c2f into tastejs:gh-pages
@passy
Owner

And thanks for the quick response, @eastridge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 26, 2013
  1. @passy

    Thorax: Removed on-ready init

    passy authored
This page is out of date. Refresh to see the latest.
View
6 labs/architecture-examples/thorax/js/app.js
@@ -1,8 +1,8 @@
-/*global $, Thorax, Backbone*/
+/*global Thorax, Backbone*/
/*jshint unused:false*/
var ENTER_KEY = 13;
-$(function () {
+(function () {
'use strict';
// Kick things off by creating the **App**.
var view = new Thorax.Views.app({
@@ -10,4 +10,4 @@ $(function () {
});
view.appendTo('body');
Backbone.history.start();
-});
+}());
View
6 labs/architecture-examples/thorax/js/views/app.js
@@ -1,5 +1,5 @@
-/*global Thorax, $, ENTER_KEY*/
-$(function () {
+/*global Thorax, ENTER_KEY*/
+(function () {
'use strict';
// The Application
@@ -66,4 +66,4 @@ $(function () {
});
}
});
-});
+}());
View
6 labs/architecture-examples/thorax/js/views/todo-item.js
@@ -1,5 +1,5 @@
-/*global Thorax, $, ENTER_KEY*/
-$(function () {
+/*global Thorax, ENTER_KEY*/
+(function () {
'use strict';
// Todo Item View
@@ -65,4 +65,4 @@ $(function () {
this.model.destroy();
}
});
-});
+}());
Something went wrong with that request. Please try again.