Added Halo TodoMVC #490

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

I have completed creating a TodoMVC for Halo. Techincally, this should be coming from the Ensighten account but there are some lockout issues going on.

Case for Halo

Halo does one thing really well: modularlity. It was built on it and eats it day and night.

By not providing HTML helpers on the JavaScript level, but providing an extensible view build it encourages abstracting common view patterns. This also allows for a flat hierarchy for views since everything acts as a mixin.

Additionally, the controllers allow for easy breaking out and down of finer logic into its own module.

Halo doesn't handle models too well yet but that is because it was designed to let that heavy work to be handled by an API.

I did go against the rules a little bit with my implementation for state. However, this is because I strongly dislike hard coded links for pages. The URL should be maintained by the application and I don't qualify HTML as being intelligent enough to manage a complex state.

@twolfson twolfson added a commit to Ensighten/todomvc that referenced this pull request Apr 4, 2013

@twolfson twolfson Added README for tastejs/todomvc#490 a5866f5

@twolfson twolfson added a commit to Ensighten/todomvc that referenced this pull request Apr 4, 2013

@twolfson twolfson Beginning to add in Halo
Copy/pasted index.html to start from and added dev script

Added version.txt to ignore list

Deleted version.txt

Attempting to load main controller but failing =(

Ran into the ever-so common error o_o

Successfully getting back content =D

Working through set up of config

Having trouble running handlebars =_=

Found the troll. Handlebars is defined as well =_=

Removing jshintrc because it is annoying the fuck out of me.

Adding in a todos model

Slowly making progress while getting sidetracked elsewhere

Corrected footer

Rendering content successfully =)

Filling out hooks for restarting and such

Working through creation and saving

Successfully adding new todos =)

Adjusted naming. Om nom nom

Defining editable bindings and whatnot

Reconfigured layout

Verified editable is working -- need to break it down though

Re-arranged editable

Repaired saving issue

Successfully updating items

Added complete/uncomplete functionality

Added deletion functionality

Was looking at the wrong page -- fixed deletion issue

Hiding/showing checkbox when it is needed or not

Added more to check/uncheck logic -- main is getting bloated now =_=

Reorganizing code for modularity's sake. woo.

Working on adding footer

Footer is functioning nicely =)

Added in state and it is almost functional

So close to being done with footer =3

Added radio plugin. woot.

Fixed up issues with radio. Looks/works great

All done with app -- now to do JSHint cleanup in a separate branch and whatnot

Added back jshint and $ to Builder.$

Use strict all the things

Finished up converting to jshint acceptable content

Added conditional showing of /

Added plural handling

Dealing with hash -_-

Added killswitch for dev files

Tweaks to rm.dev.sh

Added README for tastejs/todomvc#490

Tweaks to README
ef8b012

@twolfson twolfson added a commit to Ensighten/todomvc that referenced this pull request Apr 4, 2013

@twolfson twolfson Beginning to add in Halo
Copy/pasted index.html to start from and added dev script

Added version.txt to ignore list

Deleted version.txt

Attempting to load main controller but failing =(

Ran into the ever-so common error o_o

Successfully getting back content =D

Working through set up of config

Having trouble running handlebars =_=

Found the troll. Handlebars is defined as well =_=

Removing jshintrc because it is annoying the fuck out of me.

Adding in a todos model

Slowly making progress while getting sidetracked elsewhere

Corrected footer

Rendering content successfully =)

Filling out hooks for restarting and such

Working through creation and saving

Successfully adding new todos =)

Adjusted naming. Om nom nom

Defining editable bindings and whatnot

Reconfigured layout

Verified editable is working -- need to break it down though

Re-arranged editable

Repaired saving issue

Successfully updating items

Added complete/uncomplete functionality

Added deletion functionality

Was looking at the wrong page -- fixed deletion issue

Hiding/showing checkbox when it is needed or not

Added more to check/uncheck logic -- main is getting bloated now =_=

Reorganizing code for modularity's sake. woo.

Working on adding footer

Footer is functioning nicely =)

Added in state and it is almost functional

So close to being done with footer =3

Added radio plugin. woot.

Fixed up issues with radio. Looks/works great

All done with app -- now to do JSHint cleanup in a separate branch and whatnot

Added back jshint and $ to Builder.$

Use strict all the things

Finished up converting to jshint acceptable content

Added conditional showing of /

Added plural handling

Dealing with hash -_-

Added killswitch for dev files

Tweaks to rm.dev.sh

Added README for tastejs/todomvc#490

Tweaks to README

Removed dev items
776769c

twolfson commented Apr 4, 2013

@addyosmani I have added a README for Halo. Let me know if you need any more info. Thanks =)

Owner

addyosmani commented Apr 10, 2013

Awesome! Thanks for sending this through :) @passy and @sindresorhus will probably have some further comments on the code style but I'm going to review Halo once more at a framework level to determine if it would be a good fit for the project. Really appreciate the PR.

Owner

sindresorhus commented Apr 11, 2013

@twolfson Can you squash your commits and add the dependencies as Bower dependencies?

I could have sworn I sqaushed those =/ I will fix those issues by the end of the weekend. Thanks! =)

@sindresorhus I am working on this right now but don't want to do unnecessary work. Should I be pointing requirejs towards the components folder?

I would prefer that all of the non-MVC files live in the same directory (i.e. public/js) which is the current setup.

@twolfson twolfson added a commit to twolfson/todomvc that referenced this pull request Apr 14, 2013

@twolfson twolfson Beginning to add in Halo
Copy/pasted index.html to start from and added dev script

Added version.txt to ignore list

Deleted version.txt

Attempting to load main controller but failing =(

Ran into the ever-so common error o_o

Successfully getting back content =D

Working through set up of config

Having trouble running handlebars =_=

Found the troll. Handlebars is defined as well =_=

Removing jshintrc because it is annoying the fuck out of me.

Adding in a todos model

Slowly making progress while getting sidetracked elsewhere

Corrected footer

Rendering content successfully =)

Filling out hooks for restarting and such

Working through creation and saving

Successfully adding new todos =)

Adjusted naming. Om nom nom

Defining editable bindings and whatnot

Reconfigured layout

Verified editable is working -- need to break it down though

Re-arranged editable

Repaired saving issue

Successfully updating items

Added complete/uncomplete functionality

Added deletion functionality

Was looking at the wrong page -- fixed deletion issue

Hiding/showing checkbox when it is needed or not

Added more to check/uncheck logic -- main is getting bloated now =_=

Reorganizing code for modularity's sake. woo.

Working on adding footer

Footer is functioning nicely =)

Added in state and it is almost functional

So close to being done with footer =3

Added radio plugin. woot.

Fixed up issues with radio. Looks/works great

All done with app -- now to do JSHint cleanup in a separate branch and whatnot

Added back jshint and $ to Builder.$

Use strict all the things

Finished up converting to jshint acceptable content

Added conditional showing of /

Added plural handling

Dealing with hash -_-

Added killswitch for dev files

Tweaks to rm.dev.sh

Added README for tastejs/todomvc#490

Tweaks to README

Added jqueryp to dependencies

Added todomvc-common

Removed dev files
2301414

@passy passy commented on an outdated diff Apr 18, 2013

...xamples/halo/components/todomvc-common/component.json
@@ -0,0 +1,12 @@
+{
+ "name": "todomvc-common",
+ "version": "0.1.4",
+ "gitHead": "7c96d5a9cde7e04173544f2b477deedb1b774c4e",
+ "_id": "todomvc-common@0.1.4",
+ "readme": "ERROR: No README.md file found!",
+ "description": "ERROR: No README.md file found!",
+ "repository": {
+ "type": "git",
+ "url": "git://github.com/tastejs/todomvc-common.git"
+ }
+}
@passy

passy Apr 18, 2013

Member

We try to keep it minimal, so you can remove all component.json files in the subdirectories.

@twolfson twolfson added a commit to Ensighten/todomvc that referenced this pull request Apr 20, 2013

@twolfson twolfson Beginning to add in Halo
Copy/pasted index.html to start from and added dev script

Added version.txt to ignore list

Deleted version.txt

Attempting to load main controller but failing =(

Ran into the ever-so common error o_o

Successfully getting back content =D

Working through set up of config

Having trouble running handlebars =_=

Found the troll. Handlebars is defined as well =_=

Removing jshintrc because it is annoying the fuck out of me.

Adding in a todos model

Slowly making progress while getting sidetracked elsewhere

Corrected footer

Rendering content successfully =)

Filling out hooks for restarting and such

Working through creation and saving

Successfully adding new todos =)

Adjusted naming. Om nom nom

Defining editable bindings and whatnot

Reconfigured layout

Verified editable is working -- need to break it down though

Re-arranged editable

Repaired saving issue

Successfully updating items

Added complete/uncomplete functionality

Added deletion functionality

Was looking at the wrong page -- fixed deletion issue

Hiding/showing checkbox when it is needed or not

Added more to check/uncheck logic -- main is getting bloated now =_=

Reorganizing code for modularity's sake. woo.

Working on adding footer

Footer is functioning nicely =)

Added in state and it is almost functional

So close to being done with footer =3

Added radio plugin. woot.

Fixed up issues with radio. Looks/works great

All done with app -- now to do JSHint cleanup in a separate branch and whatnot

Added back jshint and $ to Builder.$

Use strict all the things

Finished up converting to jshint acceptable content

Added conditional showing of /

Added plural handling

Dealing with hash -_-

Added killswitch for dev files

Tweaks to rm.dev.sh

Added README for tastejs/todomvc#490

Tweaks to README

Added jqueryp to dependencies

Added todomvc-common

Refactored rm.dev.sh

Removed dev items
8d7fd08
@twolfson twolfson Beginning to add in Halo
Copy/pasted index.html to start from and added dev script

Added version.txt to ignore list

Deleted version.txt

Attempting to load main controller but failing =(

Ran into the ever-so common error o_o

Successfully getting back content =D

Working through set up of config

Having trouble running handlebars =_=

Found the troll. Handlebars is defined as well =_=

Removing jshintrc because it is annoying the fuck out of me.

Adding in a todos model

Slowly making progress while getting sidetracked elsewhere

Corrected footer

Rendering content successfully =)

Filling out hooks for restarting and such

Working through creation and saving

Successfully adding new todos =)

Adjusted naming. Om nom nom

Defining editable bindings and whatnot

Reconfigured layout

Verified editable is working -- need to break it down though

Re-arranged editable

Repaired saving issue

Successfully updating items

Added complete/uncomplete functionality

Added deletion functionality

Was looking at the wrong page -- fixed deletion issue

Hiding/showing checkbox when it is needed or not

Added more to check/uncheck logic -- main is getting bloated now =_=

Reorganizing code for modularity's sake. woo.

Working on adding footer

Footer is functioning nicely =)

Added in state and it is almost functional

So close to being done with footer =3

Added radio plugin. woot.

Fixed up issues with radio. Looks/works great

All done with app -- now to do JSHint cleanup in a separate branch and whatnot

Added back jshint and $ to Builder.$

Use strict all the things

Finished up converting to jshint acceptable content

Added conditional showing of /

Added plural handling

Dealing with hash -_-

Added killswitch for dev files

Tweaks to rm.dev.sh

Added README for tastejs/todomvc#490

Tweaks to README

Added jqueryp to dependencies

Added todomvc-common

Refactored rm.dev.sh

Removed unnecessary component.json

Removed bower.json as it is redundant as well

Fixed rebase command in rm.dev.sh

Removed dev items
229f25e

@passy I have removed the outstanding todomvc-common/component.json and jqueryp/bower.json. Let me know if there is anything else I should change.

Member

passy commented Apr 24, 2013

Hey @twolfson, we had a long internal discussion and came to the conclusion that we would rather not include a Halo in the official examples for the time being. We really appreciate the effort you put into it and would like if you could add your app to the wiki. We feel that Halo has too many open issues at the moment to be used productively, like the fundamental design question whether models should be supported or not. Also the project activity is rather low lately.

Thanks for understanding. :)

passy closed this Apr 24, 2013

Thanks you guys. I totally understand, there would be a flooded repository if you let in every MV*. Thank you for your consideration and I will toss Halo onto the wiki =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment