Make all _gaq config options global (window) #512

Merged
merged 1 commit into from Apr 2, 2013

Projects

None yet

3 participants

@danshearmur

I'm pretty sure the google analytics code (in base.js) doesn't fire because the config needs to be global.

Normally the object is set up with var in the global scope, but these are all in IFFE.

Screen Shot 2013-04-02 at 16 29 03

As you can see there is no call to http://www.google-analytics.com/__utm.gif

@sindresorhus sindresorhus merged commit 9de7041 into tastejs:gh-pages Apr 2, 2013
Member
passy commented Apr 2, 2013

Thanks! I can update this in the bower component.

Owner

This is why I love Open Source. People looking over and fixing my stupid mistakes.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment