Skip to content

[React] New main todomvc with fixes and React version bump #855

Merged
merged 1 commit into from Feb 21, 2014

3 participants

@chenglou

Fixes all the stuff from #785 too.

BTW what happened between this update and the last? Seems lots of new files in the deps.

@passy
TasteJS member
passy commented Feb 20, 2014

@chenglou Thanks for the update. Could you make sure not to add any unneeded files?

@chenglou

@passy I'm not sure what happened, I just did bower install. Last time, iirc it ignored the files correctly?
Edit: this .gitignore change? 3355fd7

@passy
TasteJS member
passy commented Feb 20, 2014

@chenglou Usually you just need to make sure to not add everything in your folders, ie. use git add -u and manually add what's missing instead of git add ..

@chenglou

@passy ah, alright. Pushed again.
Most changes are from #785.

@passy
TasteJS member
passy commented Feb 21, 2014

I like the changes and E2E test suite is passing. Cheers! :)

@passy passy merged commit 904aa5a into tastejs:gh-pages Feb 21, 2014
@chenglou chenglou deleted the chenglou:new-react branch Feb 21, 2014
@chenglou chenglou added a commit to chenglou/todomvc that referenced this pull request Feb 21, 2014
@chenglou chenglou [React] New react-backbone todomvc with fixes and React version bump
Like #855, bumped React version (along with all the other deps) and made
some fixes.
bf18ccb
@Daniel-Hug Daniel-Hug added a commit that referenced this pull request Feb 22, 2014
@chenglou chenglou [React] New react-backbone todomvc with fixes and React version bump
Like #855, bumped React version (along with all the other deps) and made
some fixes.
dd1f2e0
@dprotti dprotti added a commit that referenced this pull request Apr 2, 2014
@chenglou chenglou [React] New react-backbone todomvc with fixes and React version bump
Like #855, bumped React version (along with all the other deps) and made
some fixes.
e78b6a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.