Pull fixes to oer_license_parser.js, capret-piwik.js #10

Merged
merged 6 commits into from Sep 7, 2012

Conversation

Projects
None yet
2 participants
@nfreear
Contributor

nfreear commented Sep 7, 2012

Hi,
Would you like to pull these fixes and additions? Issues #6, #7, #8.

Fixes for #9 to follow.

Best wishes,

Nick

nfreear added some commits Aug 31, 2012

Bug #6, Fixing an MSIE 8 bug in oer_license_parser Javascript..
* Check n.hasAttributes() is defined before de-referencing..
* is_parseable_node JS function
* #6
Issue #7, Extending capret.js Javascript - to work with Piwik..
* Initial unmodified copy of capret.js
* #7
Bug #8, Fix for MSIE 8 in capret-piwik.js Javascript..
* Internet Explorer was not requesting the beacon GIF from Piwik on copy
* #8
Issue #7, Fixes to capret-piwik.js - so the tracking-GIF works when p…
…asted..

* URL encode '_cvar' custom variables JSON array, url, action_name segments etc.
* Add 'copyTime' (ct) to '_cvar' custom variables,
* Tidied Javascript.
Issue #7, Numerous small fixes/ mods. to capret-piwik Javascript..
* Appending '/ CaPReT' on the Piwik action_name,
* @data-piwik-src-ref <script> attribute - switch...
* ..Switch - put 'source' URL in Piwik's 'urlref' parameter (default, 1)..
* ..Or, put source URL in Piwik 'url' parameter (0)
* Also, put source URL in '_cvar'[1] - custom variables

jbasdf added a commit that referenced this pull request Sep 7, 2012

Merge pull request #10 from IET-OU/master
Pull fixes to oer_license_parser.js, capret-piwik.js

@jbasdf jbasdf merged commit 53ebf0f into tatemae:master Sep 7, 2012

@jbasdf

This comment has been minimized.

Show comment
Hide comment
@jbasdf

jbasdf Sep 7, 2012

Collaborator

Hi Nick,

I pulled in the changes. Thanks for the updates.

Thanks,
Justin

On Thu, Sep 6, 2012 at 11:23 PM, Nick Freear notifications@github.comwrote:

Hi,
Would you like to pull these fixes and additions? Issues #6#6,
#7 #7, #8#8
.

Fixes for #9 #9 to follow.

Best wishes,

Nick

You can merge this Pull Request by running:

git pull https://github.com/IET-OU/capret master

Or view, comment on, or merge it at:

#10
Commit Summary

  • Bug #6 #6, Fixing an MSIE
    8 bug in oer_license_parser Javascript..
  • Issue #7 #7, Extending
    capret.js Javascript - to work with Piwik..
  • Issue #7 #7, Initial
    modifications for capret-piwik Javascript
  • Bug #8 #8, Fix for MSIE 8
    in capret-piwik.js Javascript..
  • Issue #7 #7, Fixes to
    capret-piwik.js - so the tracking-GIF works when p…
  • Issue #7 #7, Numerous
    small fixes/ mods. to capret-piwik Javascript..

File Changes

  • A public/js/capret-piwik.js (90)
  • M public/js/oer_license_parser.js (1)

Patch Links

Collaborator

jbasdf commented Sep 7, 2012

Hi Nick,

I pulled in the changes. Thanks for the updates.

Thanks,
Justin

On Thu, Sep 6, 2012 at 11:23 PM, Nick Freear notifications@github.comwrote:

Hi,
Would you like to pull these fixes and additions? Issues #6#6,
#7 #7, #8#8
.

Fixes for #9 #9 to follow.

Best wishes,

Nick

You can merge this Pull Request by running:

git pull https://github.com/IET-OU/capret master

Or view, comment on, or merge it at:

#10
Commit Summary

  • Bug #6 #6, Fixing an MSIE
    8 bug in oer_license_parser Javascript..
  • Issue #7 #7, Extending
    capret.js Javascript - to work with Piwik..
  • Issue #7 #7, Initial
    modifications for capret-piwik Javascript
  • Bug #8 #8, Fix for MSIE 8
    in capret-piwik.js Javascript..
  • Issue #7 #7, Fixes to
    capret-piwik.js - so the tracking-GIF works when p…
  • Issue #7 #7, Numerous
    small fixes/ mods. to capret-piwik Javascript..

File Changes

  • A public/js/capret-piwik.js (90)
  • M public/js/oer_license_parser.js (1)

Patch Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment