New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using this on Vercel it breaks Vercel comments #12
Comments
|
@andrewdoro can you provide a link to the source code for this project, and clarify what you mean by “it stops working” |
|
Stops working means you can't use Vercel comments anymore. They aren't displayed anymore. The code isn't important. This happens with all preview pages deployed on vercel. |
|
@Jak2k or @andrewdoro can you recreate this issue outside of Vercel? This strikes me as Vercel or application specific and not a bug in this package. You may need to further research Vercel commenting or contact their support to ask about usage with service workers. |
|
It is not possible to recreate outside of vercel, because the bug is related to vercel feature, which is broken by the service worker. Vercel comments are a feature, which allows to comment on preview depoyments. |
|
@Jak2k you’re going to need to either dig into the wiring for vercel comments to understand how to make it work with a service worker, or disable the plugin (so no service worker is generated) in preview builds. |
If you enter this link first time Vercel comments would work
https://aether-stack-86mccaup0-elfandreis.vercel.app/
After another refresh it stops working. You need to clean the storage cache to make it work again
The text was updated successfully, but these errors were encountered: