Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added base and wrapper for the FileSystemWatcher class #59

Merged
merged 1 commit into from Feb 21, 2014

Conversation

Projects
None yet
2 participants
Contributor

KallDrexx commented Feb 19, 2014

Added classes to make mocking the file system watcher easier.

@tathamoddie tathamoddie commented on an outdated diff Feb 20, 2014

System.IO.Abstractions.jmconfig
@@ -0,0 +1 @@
+<?xml version="1.0" encoding="utf-8"?><Configuration xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><DontShowAgainInSolution>false</DontShowAgainInSolution></Configuration>
@tathamoddie

tathamoddie Feb 20, 2014

Owner

What's this file?

Owner

tathamoddie commented Feb 20, 2014

The .jmconfig file looks erroneous. The rest looks good. If you can resubmit without that file, I'll accept and publish straight way.

Contributor

KallDrexx commented Feb 20, 2014

Removed the file. Sorry, no idea where that came from O.o

Contributor

KallDrexx commented Feb 20, 2014

Actually hold off on accepting the pull request. I think I didn't properly test the Wrapper class, as I don't think events will actually bubble from the internal watcher class to the wrapper. I'll fix that tonight, sorry.

Owner

tathamoddie commented Feb 21, 2014

No probs.

When you're working on it, can you squash your commits together too? Right now for example, there's one commit that introduces the .jmconfig file, then another that removes it. That makes the history a bit messy. Luckily, we can rework the history as much as we want in the fork! :)

To do so:

  1. Run git rebase -i
  2. Change all but the first commit from pick to squash
  3. When prompted, supply a new commit message that describes your total change
  4. git push -f

Hit me up here if you need any help.

@KallDrexx KallDrexx Added base and wrapper for the FileSystemWatcher class
Removed jmconfig file (no idea where that came from)

Updated Base and wrapper classes to properly deal with the events and bubble up the concrete FileSystemWatcher events up to the wrapper class.
0dc8f36
Contributor

KallDrexx commented Feb 21, 2014

Code fixed up so events correctly bubble up to the wrapper, and I think I got everything squashed together (never done that before, took me a bit to get right).

Owner

tathamoddie commented Feb 21, 2014

Looks good! If you look at https://github.com/tathamoddie/System.IO.Abstractions/pull/59/commits, you can now see that there's only one commit there instead of 3.

(Minor note: By default squash appends all the commit messages together, but then gives you a chance to edit this. In this case you've kept the merged messages, so it refers to removing the .jmconfig file even though it never existed now. Just writing this up for your own knowledge: I'm not going to be pedantic enough to ask you to fix it. If you did want to though, you'd just run git rebase -i again and use reword.)

@tathamoddie tathamoddie added a commit that referenced this pull request Feb 21, 2014

@tathamoddie tathamoddie Merge pull request #59 from KallDrexx/FileSystemWatcher-Abstraction
Added base and wrapper for the FileSystemWatcher class
7aed17b

@tathamoddie tathamoddie merged commit 7aed17b into tathamoddie:master Feb 21, 2014

1 check passed

default Finished TeamCity Build System.IO.Abstractions :: Build : Tests passed: 183
Details
Owner

tathamoddie commented Feb 21, 2014

This has been merged now, so the build server will automatically push it up to NuGet within a minute or two.

Contributor

KallDrexx commented Feb 21, 2014

Awesome, good to know about the merge message, sorry about that :).

Love the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment