code cleanup #63

Merged
merged 1 commit into from Mar 2, 2014

2 participants

@manne
Collaborator

i ran code analysis and did some clean up

@tathamoddie tathamoddie commented on the diff Feb 27, 2014
System.IO.Abstractions/FileSystemWatcherWrapper.cs
namespace System.IO.Abstractions
{
[Serializable]
public class FileSystemWatcherWrapper : FileSystemWatcherBase
{
+ [NonSerialized]
@tathamoddie
Owner
tathamoddie added a line comment Feb 27, 2014

Why do we need this?

@manne
Collaborator
manne added a line comment Feb 28, 2014

the type FileSystemWatcher itself is not serializable, because FileSystemWrapper is serializable the field should be marked with NonSerialized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@tathamoddie tathamoddie merged commit 3c64e7e into tathamoddie:master Mar 2, 2014

1 check passed

Details default Finished TeamCity Build System.IO.Abstractions :: Build : Tests passed: 183
@manne manne deleted the manne:cleanup branch Mar 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment