feat: Made space for buttons on address bar

tathyagarg · tathyagarg · commit 251e78106624 · 2026-02-24T13:13:01.000+05:30
diff --git a/harbor/engine/res/pages/tab.html b/harbor/engine/res/pages/tab.html
@@ -5,23 +5,29 @@
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <title>New Tab</title>
   <style>
-    body {
+    html, body {
         background-color: #11111b;
+        color: #a6adc8;
     }
 
     h1 {
         color: #cdd6f4;
     }
 
-    p {
-        color: #a6adc8;
+    a {
+        color: #89b4fa;
     }
 
-    h1, p { margin-left: 2rem; }
+    h1, h2, p, ul { margin-left: 2rem; }
   </style>
 </head>
 <body>
   <h1>Welcome to your new tab!</h1>
   <p>This is a custom new tab page.</p>
+  <h2>Awesome Flavortown projects</h2>
+  <ul>
+      <li><a href="https://flavortown.hackclub.com/projects/13380">Override.exe</a> - by @rupnil.codes</li>
+      <li><a href="https://flavortown.hackclub.com/projects/12732">Shish's Personal Website</a> - by @Shish</li>
+  </ul>
 </body>
 </html>
diff --git a/harbor/engine/src/globals.rs b/harbor/engine/src/globals.rs
@@ -25,6 +25,9 @@ pub const TABS_BAR_OFFSET: fn(f64, f64) -> (f64, f64) =
 pub const ADDRESS_BAR_OFFSET: fn(f64, f64) -> (f64, f64) =
     |_window_width, window_height| (0.0, (window_height * 0.05).min(50.0));
 
+pub const ADDRESS_BAR_ADDRESS_OFFSET: fn(f64, f64) -> (f64, f64) =
+    |window_width, _window_height| (window_width * 0.1, 0.0);
+
 pub const TOOLBAR_OFFSET: fn(f64, f64) -> (f64, f64) = |window_width, window_height| {
     let tabs_bar_offset = TABS_BAR_OFFSET(window_width, window_height);
     let address_bar_offset = ADDRESS_BAR_OFFSET(window_width, window_height);
diff --git a/harbor/engine/src/render/mod.rs b/harbor/engine/src/render/mod.rs
@@ -16,8 +16,8 @@ use crate::css::r#box::Box as CssBox;
 use crate::css::colors::UsedColor;
 use crate::css::layout::Layout;
 use crate::globals::{
-    ADDRESS_BAR_OFFSET, INITIAL_WINDOW_HEIGHT, INITIAL_WINDOW_WIDTH, MINIMUM_WINDOW_HEIGHT,
-    MINIMUM_WINDOW_WIDTH, TAB_WIDTH, TABS_BAR_OFFSET, TOOLBAR_OFFSET,
+    ADDRESS_BAR_ADDRESS_OFFSET, ADDRESS_BAR_OFFSET, INITIAL_WINDOW_HEIGHT, INITIAL_WINDOW_WIDTH,
+    MINIMUM_WINDOW_HEIGHT, MINIMUM_WINDOW_WIDTH, TAB_WIDTH, TABS_BAR_OFFSET, TOOLBAR_OFFSET,
 };
 use crate::html5::dom::Document;
 use crate::html5::elements::anchor::AnchorElement;
@@ -230,6 +230,11 @@ impl ApplicationHandler<AppEvent> for App {
                 let address_bar_offset =
                     ADDRESS_BAR_OFFSET(state.config.width as f64, state.config.height as f64);
 
+                let address_bar_address_offset = ADDRESS_BAR_ADDRESS_OFFSET(
+                    state.config.width as f64,
+                    state.config.height as f64,
+                );
+
                 let toolbar_offset =
                     TOOLBAR_OFFSET(state.config.width as f64, state.config.height as f64);
 
@@ -251,8 +256,11 @@ impl ApplicationHandler<AppEvent> for App {
                         }
                     }
                 } else if state.cursor_position.1 < tabs_bar_offset.1 + address_bar_offset.1 {
-                    if elem_state == ElementState::Pressed {
-                        state.address_bar_active = true;
+                    if state.cursor_position.0 > address_bar_address_offset.0 {
+                        if elem_state == ElementState::Pressed {
+                            state.address_bar_active = true;
+                        }
+                    } else {
                     }
                 } else {
                     if let Some(root) = layout.root_box.as_ref() {
diff --git a/harbor/engine/src/render/state.rs b/harbor/engine/src/render/state.rs
@@ -11,8 +11,8 @@ use crate::{
         properties::FontStyle,
     },
     globals::{
-        ADDRESS_BAR_OFFSET, DEFAULT_FONT_FAMILY, DEFAULT_FONT_SIZE, DEFAULT_FONT_STYLE_ITALIC,
-        DEFAULT_FONT_WEIGHT, TAB_WIDTH, TABS_BAR_OFFSET, TOOLBAR_OFFSET,
+        ADDRESS_BAR_ADDRESS_OFFSET, ADDRESS_BAR_OFFSET, DEFAULT_FONT_FAMILY, DEFAULT_FONT_SIZE,
+        DEFAULT_FONT_STYLE_ITALIC, DEFAULT_FONT_WEIGHT, TAB_WIDTH, TABS_BAR_OFFSET, TOOLBAR_OFFSET,
     },
     html5::dom::{Document, Element, NodeKind},
     render::{
@@ -289,6 +289,8 @@ impl WindowState {
         let tabs_bar_offset = TABS_BAR_OFFSET(self.config.width as f64, self.config.height as f64);
         let address_bar_offset =
             ADDRESS_BAR_OFFSET(self.config.width as f64, self.config.height as f64);
+        let address_bar_address_offset =
+            ADDRESS_BAR_ADDRESS_OFFSET(self.config.width as f64, self.config.height as f64);
 
         let color = if self.address_bar_active {
             ACTIVE_ADDRESS_BAR_COLOR
@@ -316,7 +318,7 @@ impl WindowState {
         render_pass.draw(0..verts.len() as u32, 0..1);
 
         let adj_position = (
-            address_bar_offset.0 + 10.0,
+            address_bar_offset.0 + address_bar_address_offset.0,
             tabs_bar_offset.1 + address_bar_offset.1 / 4.0,
         );
 
