fix: allow building on msrv 1.57 (#170)

Author: amrbashir

.changes/msrv-1.57.md

@@ -0,0 +1,5 @@
+---
+"create-tauri-app": "patch"
+---
+
+Fix build on MSRV 1.57.

.changes/next.md

@@ -1,5 +1,6 @@
 ---
 "create-tauri-app": "patch"
+"create-tauri-app-js": "patch"
 ---
 
 Fix building in `next` and `next-ts` templates by removing the `experimental` option from `next.config.js` since `images.unoptimized` is now stable.

.github/workflows/cli-test.yml

@@ -30,14 +30,17 @@ concurrency:
 jobs:
   test:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        toolchain: [1.57, stable]
 
     steps:
       - uses: actions/checkout@v2
 
       - name: install stable
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: stable
+          toolchain: ${{ matrix.toolchain }}
           override: true
 
       - uses: actions-rs/cargo@v1

Cargo.toml

@@ -6,4 +6,3 @@ panic = "abort"
 codegen-units = 1
 lto = true
 opt-level = "s"
-strip = true

packages/cli/Cargo.toml

@@ -10,6 +10,7 @@ repository = "https://github.com/tauri-apps/create-tauri-app"
 keywords = [ "tauri" ]
 categories = [ "gui" ]
 exclude = [ "/node" ]
+rust-version = "1.57"
 
 [[bin]]
 name = "cargo-create-tauri-app"

packages/cli/src/cli.rs

@@ -56,14 +56,17 @@ pub fn parse(argv: Vec<OsString>, bin_name: Option<String>) -> anyhow::Result<Ar
             desc = env!("CARGO_PKG_DESCRIPTION"),
             managers = PackageManager::ALL
                 .iter()
-                .map(|e| format!("{GREEN}{e}{RESET}"))
+                .map(|e| format!("{}{}{}", GREEN, e, RESET))
                 .collect::<Vec<_>>()
                 .join(", "),
             fragments = Template::ALL
                 .iter()
-                .map(|e| format!("{GREEN}{e}{RESET}"))
+                .map(|e| format!("{}{}{}", GREEN, e, RESET))
                 .collect::<Vec<_>>()
                 .join(", "),
+            GREEN = GREEN,
+            RESET = RESET,
+            YELLOW = YELLOW,
         );
 
         println!("{}", help);

packages/cli/src/lib.rs

@@ -18,7 +18,13 @@ where
     A: Into<OsString> + Clone,
 {
     if let Err(e) = try_run(args, bin_name) {
-        eprintln!("{BOLD}{RED}error{RESET}: {e:#}");
+        eprintln!(
+            "{BOLD}{RED}error{RESET}: {:#}",
+            e,
+            BOLD = BOLD,
+            RED = RED,
+            RESET = RESET
+        );
         exit(1);
     }
 }
@@ -95,7 +101,12 @@ where
                 .interact()?
         };
         if !overrwite {
-            eprintln!("{BOLD}{RED}✘{RESET} Operation Cancelled");
+            eprintln!(
+                "{BOLD}{RED}✘{RESET} Operation Cancelled",
+                BOLD = BOLD,
+                RED = RED,
+                RESET = RESET
+            );
             exit(1);
         }
     };
@@ -132,8 +143,14 @@ where
 
     if !templates.contains(&template) {
         eprintln!(
-            "{BOLD}{RED}error{RESET}: the {GREEN}{template}{RESET} template is not suppported for the {GREEN}{pkg_manager}{RESET} package manager\n       possible templates for {GREEN}{pkg_manager}{RESET} are: [{}]",
-            templates.iter().map(|e|format!("{GREEN}{e}{RESET}")).collect::<Vec<_>>().join(", ")
+            "{BOLD}{RED}error{RESET}: the {GREEN}{}{RESET} template is not suppported for the {GREEN}{pkg_manager}{RESET} package manager\n       possible templates for {GREEN}{pkg_manager}{RESET} are: [{}]",
+            template,
+            templates.iter().map(|e|format!("{GREEN}{}{RESET}", e, GREEN = GREEN, RESET = RESET)).collect::<Vec<_>>().join(", "),
+            pkg_manager = pkg_manager,
+            BOLD = BOLD,
+            RED = RED,
+            RESET = RESET,
+            GREEN = GREEN,
         );
         exit(1);
     }
@@ -147,7 +164,15 @@ where
     template.render(&target_dir, pkg_manager, &package_name)?;
 
     println!();
-    println!("{ITALIC}{DIM}Please follow{DIMRESET} {BLUE}https://tauri.app/v1/guides/getting-started/prerequisites{WHITE} {DIM}to install the needed prerequisites, if you haven't already.{DIMRESET}{RESET}");
+    println!(
+        "{ITALIC}{DIM}Please follow{DIMRESET} {BLUE}https://tauri.app/v1/guides/getting-started/prerequisites{WHITE} {DIM}to install the needed prerequisites, if you haven't already.{DIMRESET}{RESET}",
+        ITALIC = ITALIC,
+        DIM = DIM,
+        DIMRESET = DIMRESET,
+        WHITE = WHITE,
+        BLUE = BLUE,
+        RESET=RESET
+    );
     if let Some(info) = template.post_init_info() {
         println!("{}", info);
     }

packages/cli/src/package_manager.rs

@@ -6,16 +6,21 @@ use std::{fmt::Display, str::FromStr};
 
 use crate::template::Template;
 
-#[derive(Debug, Clone, Copy, Default, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 #[non_exhaustive]
 pub enum PackageManager {
-    #[default]
     Cargo,
     Pnpm,
     Yarn,
     Npm,
 }
 
+impl Default for PackageManager {
+    fn default() -> Self {
+        PackageManager::Cargo
+    }
+}
+
 impl<'a> PackageManager {
     pub const ALL: &'a [PackageManager] = &[
         PackageManager::Cargo,

packages/cli/src/template.rs

@@ -13,10 +13,9 @@ use crate::{colors::*, package_manager::PackageManager};
 #[folder = "$CARGO_MANIFEST_DIR/fragments"]
 struct Fragments;
 
-#[derive(Debug, Clone, Copy, Default, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 #[non_exhaustive]
 pub enum Template {
-    #[default]
     Vanilla,
     VanillaTs,
     Vue,
@@ -34,6 +33,12 @@ pub enum Template {
     PreactTs,
 }
 
+impl Default for Template {
+    fn default() -> Self {
+        Template::Vanilla
+    }
+}
+
 impl<'a> Template {
     pub const ALL: &'a [Template] = &[
         Template::Vanilla,
@@ -55,7 +60,18 @@ impl<'a> Template {
 
     pub fn post_init_info(&self) -> Option<String> {
         match self {
-            Template::Yew => Some(format!("{ITALIC}{DIM}You also need to install{DIMRESET} {YELLOW}tauri-cli{WHITE} {DIM}({DIMRESET}{BLUE}cargo install tauri-cli{WHITE}{DIM}) and{DIMRESET} {YELLOW}trunk{WHITE} {DIM}({DIMRESET}{BLUE}https://trunkrs.dev/#install{WHITE}{DIM}){DIMRESET}{RESET}")),
+            Template::Yew => Some(
+                format!(
+                    "{ITALIC}{DIM}You also need to install{DIMRESET} {YELLOW}tauri-cli{WHITE} {DIM}({DIMRESET}{BLUE}cargo install tauri-cli{WHITE}{DIM}) and{DIMRESET} {YELLOW}trunk{WHITE} {DIM}({DIMRESET}{BLUE}https://trunkrs.dev/#install{WHITE}{DIM}){DIMRESET}{RESET}",
+                    ITALIC = ITALIC,
+                    DIM = DIM,
+                    DIMRESET = DIMRESET,
+                    YELLOW = YELLOW,
+                    WHITE = WHITE,
+                    BLUE = BLUE,
+                    RESET = RESET
+                ),
+            ),
             _ => None,
         }
     }
@@ -166,15 +182,15 @@ impl<'a> Template {
                 .next()
                 .unwrap()
                 .as_os_str()
-                == path::PathBuf::from(format!("fragment-{self}"))
+                == path::PathBuf::from(format!("fragment-{}", self))
         }) {
             write_file(&file)?;
         }
 
         // then write extra files specified in the fragment manifest
         for (src, dest) in manifest.files {
             let data = Fragments::get(&format!("_assets_/{}", src))
-                .with_context(|| format!("Failed to get asset file bytes: {src}"))?
+                .with_context(|| format!("Failed to get asset file bytes: {}", src))?
                 .data;
             let dest = target_dir.join(dest);
             let parent = dest.parent().unwrap();