fix: remove .app ending from default identifier (#900)

* Remove `.app` ending from default identifier

* Clippy

Author: Legend-Master

.changes/no-dot-app-in-default-id.md

@@ -0,0 +1,6 @@
+---
+"create-tauri-app": "minor"
+"create-tauri-app-js": "minor"
+---
+
+Changed default app identifier from `com.{package_name}.app` to `com.{user_name}.{package_name}` as `.app` causes problems on macOS

Cargo.lock

@@ -36,3 +36,4 @@ rust-embed = { version = "8.3", features = [
     "compression",
     "interpolate-folder-path",
 ] }
+whoami = { version = "1.6.0", default-features = false }

Cargo.toml

@@ -12,8 +12,8 @@ pub enum Category {
     Dotnet,
 }
 
-impl<'a> Category {
-    pub const ALL: &'a [Self] = &[Category::JsTs, Category::Rust, Category::Dotnet];
+impl Category {
+    pub const ALL: &[Self] = &[Category::JsTs, Category::Rust, Category::Dotnet];
 
     pub const fn package_managers(&self) -> &[PackageManager] {
         match self {

src/category.rs

@@ -126,7 +126,8 @@ where
     let identifier = match identifier {
         Some(name) => name,
         None => {
-            let default = format!("com.{package_name}.app");
+            let valid_user_name = utils::to_valid_pkg_name(&whoami::username());
+            let default = format!("com.{valid_user_name}.{package_name}");
             if skip {
                 default
             } else {

src/lib.rs

@@ -143,8 +143,8 @@ impl Template {
     }
 }
 
-impl<'a> Template {
-    pub const ALL: &'a [Template] = &[
+impl Template {
+    pub const ALL: &[Template] = &[
         Template::Vanilla,
         Template::VanillaTs,
         Template::Vue,