Skip to content

[FEATURE] Next and NextTs template - #137

Merged
amrbashir merged 6 commits into
tauri-apps:devfrom
0xle0ne:feature-next-nextts-template
Aug 25, 2022
Merged

[FEATURE] Next and NextTs template#137
amrbashir merged 6 commits into
tauri-apps:devfrom
0xle0ne:feature-next-nextts-template

Conversation

@0xle0ne

@0xle0ne 0xle0ne commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Hey there,
Couple months ago I made a pull request to implement next.js there.
I wrote that I would update it to work with your updated rust CLI.
So here it is

Thank you for your awesome tool,
With regards leon3s.

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening the PR again, there is some issues that needs to be fixed which I highlighted in the review below.

There is also an issue with the drop shadow of logos, I took a screenshot of it. It seems like the logos are not allowed to overflow while we need it to overflow.
image

Comment thread packages/cli/fragments/fragment-next-ts/next.config.js
Comment thread packages/cli/fragments/fragment-next-ts/src/App.css
Comment thread packages/cli/fragments/fragment-next/next.config.js
Comment thread packages/cli/fragments/fragment-next/src/App.css
@amrbashir

Copy link
Copy Markdown
Member

don't forget to run prettier from the repo root.

Comment thread packages/cli/fragments/fragment-next-ts/src/App.css Outdated

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@amrbashir
amrbashir merged commit cbe1200 into tauri-apps:dev Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants