Reincorporated Preact and PreactTS templates. - #145
Merged
Conversation
amrbashir
requested changes
Aug 28, 2022
amrbashir
left a comment
amrbashir
left a comment
Member
There was a problem hiding this comment.
I will do a full review later but for now can you add the new templates in .scripts/generate-templates-matrix.js to the Nodejs templates list so the CI would pick it up and run the test for it?
…nside the CONTRIBUTING.md for easing future contributions
Contributor
Author
|
@amrbashir I've done that modification inside |
amrbashir
requested changes
Aug 30, 2022
amrbashir
left a comment
amrbashir
left a comment
Member
There was a problem hiding this comment.
Sorry to take this long to review
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
…ore. which is more concise
…-> style, added vite class to vite logo, fixing the style logo.vite expected behaviour
amrbashir
requested changes
Aug 30, 2022
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
previously approved these changes
Aug 30, 2022
Member
|
Thank you @extrordinaire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
This PR brings back Preact and PreactTs templates to Tauri create-tauri-app CLI.