Skip to content

refactor: replace deprecated code - #182

Merged
amrbashir merged 2 commits into
tauri-apps:devfrom
xTekC:dev
Sep 19, 2022
Merged

refactor: replace deprecated code#182
amrbashir merged 2 commits into
tauri-apps:devfrom
xTekC:dev

Conversation

@xTekC

@xTekC xTekC commented Sep 18, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: xTeKc bcd3v@pm.me

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This PR replaces the deprecated JsValue::from_serde with serde_wasm_bindgen::to_value, which essentially does the same thing and converts the Rust value into a JsValue. All tests pass and everything works as expected after the refactor.

xTeKc and others added 2 commits September 18, 2022 02:54
Signed-off-by: xTeKc <bcd3v@pm.me>

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir
amrbashir merged commit 16b0210 into tauri-apps:dev Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants