Skip to content

refactor: remove vanilla templates assignment to window object - #212

Merged
amrbashir merged 2 commits into
devfrom
remove-global-window-assignment-vanilla
Oct 11, 2022
Merged

refactor: remove vanilla templates assignment to window object#212
amrbashir merged 2 commits into
devfrom
remove-global-window-assignment-vanilla

Conversation

@amrbashir

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir
amrbashir merged commit f5f8628 into dev Oct 11, 2022
@amrbashir
amrbashir deleted the remove-global-window-assignment-vanilla branch October 11, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant