fix: add typescript support in .svelte files - #277
Merged
Conversation
enable and add preprocessor for sveltekit and svelte respectively (fix #276)
amrbashir
requested changes
Dec 30, 2022
…concise Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Signed-off-by: Lukas <65358837+lukthony@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable and add preprocessor for sveltekit and svelte respectively
(fix #276)
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
In the Svelte and SvelteKit TypeScript templates, if TypeScript syntax is used inside a
.sveltefile, Vite will throw an error. For example, in a fresh SvelteKit project, if the code......is in a
.sveltefile(here it is specifically line 6), the following error is seen:This error appears in both Svelte and SvelteKit, with brand new, freshly-created projects. The fixes I found differ between Svelte and SvelteKit.
For SvelteKit, the
svelte.config.jsmust be changed from this:...to this:
In Svelte, the
package.jsonfile must be changed to add...to the devDependencies.
Further, the beginning of the
vite.config.tsfile must be changed from this:...to this:
Once these changes are made, TypeScript can be used as-expected within
.sveltefiles, in both SvelteKit and Svelte.This is my first ever pull request. Please let me know if I have done anything in error.