Update code snippets to use the platform - #331
Merged
Merged
Conversation
amrbashir
approved these changes
Feb 13, 2023
10 tasks
amrbashir
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Update code snippets to use the platform * Add change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Currently, the default greeter Tauri app when using the quickstart does not ship a valid HTML form. This is evidenced by nothing happening when pressing "Enter" after typing a name in the name input field:
This PR uses proper HTML
formelements and theironsubmithandler to have the greeter actually submit a form on Enter, instead of a button receiving a click event only in isolation. I feel this is important as it teaches newcomers stuff and we want to teach them the right stuff.Caveat
This PR doesn't touch the
yewtemplate because I don't know Rust and I'm not sure how toe.preventDefaultin anonsubmithandler with Yew. We can treat Yew separately in #332.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information