Skip to content

🔧 Fix(Fragments/Leptos): Fix unwanted refresh and update to Leptos v0.2 - #362

Merged
amrbashir merged 9 commits into
tauri-apps:devfrom
pikhosh:leptos-update
Mar 8, 2023
Merged

🔧 Fix(Fragments/Leptos): Fix unwanted refresh and update to Leptos v0.2#362
amrbashir merged 9 commits into
tauri-apps:devfrom
pikhosh:leptos-update

Conversation

@pikhosh

@pikhosh pikhosh commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Nothing...

amrbashir
amrbashir requested changes Mar 8, 2023
View reviewed changes

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Comment thread packages/cli/fragments/fragment-leptos/_Cargo.toml Outdated
Comment thread packages/cli/fragments/fragment-leptos/src/app.rs Outdated
Comment thread .changes/changes.md Outdated
pikhosh and others added 4 commits March 8, 2023 16:53
@pikhosh @amrbashir
Update packages/cli/fragments/fragment-leptos/_Cargo.toml
b848407 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@pikhosh
Update app.rs
bf333c7
@pikhosh
Merge branch 'leptos-update' of https://github.com/pikhosh/create-tau…
61e45e5 
…ri-app into leptos-update
@pikhosh @amrbashir
Update .changes/changes.md
30bc63e 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
amrbashir requested changes Mar 8, 2023
View reviewed changes
Comment thread packages/cli/fragments/fragment-leptos/_Cargo.toml Outdated
Comment thread packages/cli/fragments/fragment-leptos/src/app.rs Outdated
pikhosh and others added 2 commits March 8, 2023 17:16
@pikhosh @amrbashir
🗿 Chore: Add all necessary files to the .changes folder
451ef61 
Co-Authored-By: Amr Bashir <amr.bashir2015@gmail.com>
@pikhosh @amrbashir
🛠️ Refactor(Fragments/Leptos): Remove web-sys
81c9d9e 
Leptos v0.2 doesn't re-export the `Event` type from the `web-sys` so in order to remove the `web-sys` we need to remove the explicit type from the `update_name` closure

Co-Authored-By: Amr Bashir <amr.bashir2015@gmail.com>
@pikhosh pikhosh changed the title 🔧 Fix(Fragments/Leptos): Fix unwanted refresh and update to Leptos v0.2.1 🔧 Fix(Fragments/Leptos): Fix unwanted refresh and update to Leptos v0.2 Mar 8, 2023
amrbashir
amrbashir approved these changes Mar 8, 2023
View reviewed changes

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir
amrbashir merged commit c60e21e into tauri-apps:dev Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pikhosh @amrbashir