Skip to content

feat: show missing deps after template bootstrap - #367

Merged
amrbashir merged 13 commits into
devfrom
feat/check-deps
Mar 13, 2023
Merged

amrbashir merged 13 commits into
devfrom
feat/check-deps

Conversation

@amrbashir

@amrbashir amrbashir commented Mar 12, 2023

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lorenzolewis
lorenzolewis self-requested a review March 13, 2023 09:32

@lorenzolewis lorenzolewis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few phrasing suggestions/updates. Lmk if you think differently for any of them

Comment thread packages/cli/src/deps.rs Outdated
Comment thread packages/cli/src/deps.rs Outdated
Comment thread packages/cli/src/deps.rs Outdated
Comment thread packages/cli/src/deps.rs
Comment thread packages/cli/src/deps.rs Outdated
Comment thread packages/cli/src/deps.rs Outdated
Comment thread packages/cli/src/deps.rs Outdated
amrbashir and others added 3 commits March 13, 2023 15:03
Co-authored-by: Lorenzo Lewis <lorenzo_lewis@icloud.com>
Co-authored-by: Lorenzo Lewis <lorenzo_lewis@icloud.com>
@amrbashir
amrbashir requested a review from lorenzolewis March 13, 2023 13:10
Comment thread packages/cli/src/deps.rs Outdated
@lorenzolewis

Copy link
Copy Markdown
Member

Looks fantastic! Is there a way to write custom release notes (outside of the per-commit level) with Covector? I think this would be a good place to start doing that as a TL;DR for major/minor releases

@amrbashir
amrbashir merged commit 7b992e5 into dev Mar 13, 2023
@amrbashir
amrbashir deleted the feat/check-deps branch March 13, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants