Skip to content

style.css -> styles.css - #376

Merged
amrbashir merged 2 commits into
devfrom
simonhyll-sycamore-styles
Mar 19, 2023
Merged

style.css -> styles.css#376
amrbashir merged 2 commits into
devfrom
simonhyll-sycamore-styles

Conversation

@simonhyll

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

The Sycamore templates styles aren't being added correctly due to the name being incorrect. Changing the name should take care of that.

@amrbashir

Copy link
Copy Markdown
Member

Could you add change file as well?

@amrbashir
amrbashir merged commit 763ef80 into dev Mar 19, 2023
@amrbashir
amrbashir deleted the simonhyll-sycamore-styles branch March 19, 2023 22:31
@simonhyll

Copy link
Copy Markdown
Contributor Author

@amrbashir Thanks for making the change file, I completely forgot that you asked me to do that until just now >.<

@amrbashir

Copy link
Copy Markdown
Member

No problem! Change files are easily forgotten 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants