Skip to content

fix(solid.js): update greetMsg signal getter - #397

Merged
amrbashir merged 3 commits into
tauri-apps:devfrom
escwxyz:dev
Apr 5, 2023
Merged

fix(solid.js): update greetMsg signal getter#397
amrbashir merged 3 commits into
tauri-apps:devfrom
escwxyz:dev

Conversation

@escwxyz

@escwxyz escwxyz commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: minor change to the template (App.tsx), it should use getMsg() instead of getMsg to get the latest state

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread .changes/template-solidjs.md

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@amrbashir
amrbashir merged commit 8c2e92b into tauri-apps:dev Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants