Skip to content

fix(cli): recusively clean dirty target dir - #430

Merged
amrbashir merged 1 commit into
devfrom
fix/dirty-dir-clean
May 25, 2023
Merged

fix(cli): recusively clean dirty target dir#430
amrbashir merged 1 commit into
devfrom
fix/dirty-dir-clean

Conversation

@amrbashir

@amrbashir amrbashir commented May 25, 2023

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir
amrbashir merged commit 88944c8 into dev May 25, 2023
@amrbashir
amrbashir deleted the fix/dirty-dir-clean branch May 25, 2023 16:58
@lucasfernog

Copy link
Copy Markdown
Member

@amrbashir can't you just use https://doc.rust-lang.org/std/fs/fn.remove_dir_all.html instead?

@amrbashir

amrbashir commented May 25, 2023

Copy link
Copy Markdown
Member Author

We can't, since the target dir might be the current directory and would result in permission denied error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants