Skip to content

feat: add preact & preact-ts templates back - #455

Merged
amrbashir merged 7 commits into
tauri-apps:devfrom
rschristian:feat/preact
Jul 10, 2023
Merged

amrbashir merged 7 commits into
tauri-apps:devfrom
rschristian:feat/preact

Conversation

@rschristian

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Was given the go-ahead here: #365 (comment)

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Seems to work well, but this is my first time contributing to create-tauri-app (actually, my first time using tauri at all, despite it being on my to-do list since forever), so certainly let me know if I missed something or did something silly!

As stated in the issue, I'm happy to help out & maintain these going forward, if any changes are needed or if Preact-specific knowledge is required. I don't want to increase your maintenance burden.

Comment thread packages/cli/src/template.rs Outdated

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir changed the title feature: Add Preact & Preact-TS templates back feat: add preact & preact-ts templates back Jul 10, 2023
@amrbashir
amrbashir merged commit a092565 into tauri-apps:dev Jul 10, 2023
@rschristian
rschristian deleted the feat/preact branch July 10, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants