fix(templates/solid-ts): add vite-env.d.ts file - #476
Merged
Conversation
amrbashir
requested changes
Aug 26, 2023
amrbashir
left a comment
amrbashir
left a comment
Member
There was a problem hiding this comment.
We should instead add a file like this one https://github.com/vitejs/vite/blob/main/packages/create-vite/template-solid-ts/src/vite-env.d.ts
We don't want to set types field in tsconfig by default and let the user modify it on his own.
amrbashir
reviewed
Aug 30, 2023
amrbashir
previously approved these changes
Aug 30, 2023
amrbashir
left a comment
amrbashir
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution
amrbashir
approved these changes
Aug 30, 2023
amrbashir
changed the title
vite-env.d.ts file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information
This fixes the following typescript error