Skip to content

refactor: version aware package manager usage, fix #4, fix #2, fix #6 - #5

Merged
amrbashir merged 26 commits into
devfrom
refactor/pm-versions
Mar 3, 2022
Merged

refactor: version aware package manager usage, fix #4, fix #2, fix #6#5
amrbashir merged 26 commits into
devfrom
refactor/pm-versions

Conversation

@amrbashir

@amrbashir amrbashir commented Feb 20, 2022

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

TODOs:

  • Change file
  • Actually build and run the PR
  • Tests (another PR maybe?):
    • e2e tests with published @tauri-apps/cli ?
    • e2e tests with local @tauri-apps/cli ?
    • maybe some unit tests?

@amrbashir
amrbashir marked this pull request as draft February 20, 2022 08:47
@amrbashir amrbashir changed the title refactor: version aware package manager usage, fix #4, fix #2 refactor: version aware package manager usage, fix #4, fix #2, fix #6 Mar 1, 2022
@amrbashir
amrbashir marked this pull request as ready for review March 1, 2022 09:11
@amrbashir
amrbashir requested a review from jbolda March 1, 2022 09:12
@amrbashir

Copy link
Copy Markdown
Member Author

looks like tests pass now

jbolda
jbolda previously approved these changes Mar 2, 2022

@jbolda jbolda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where you went with the package manager. It was definitely needed. I think switching away from the shorthand pm is a good idea, but the rest are more comments than anything.

Comment thread src/index.ts Outdated
Comment thread src/recipes/cljs.ts
Comment thread src/recipes/react.ts
Comment thread test/spawn.test.mjs
@amrbashir
amrbashir merged commit a073dbc into dev Mar 3, 2022
@amrbashir
amrbashir deleted the refactor/pm-versions branch March 3, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants