refactor: version aware package manager usage, fix #4, fix #2, fix #6 - #5
Merged
Conversation
amrbashir
marked this pull request as draft
February 20, 2022 08:47
amrbashir
marked this pull request as ready for review
March 1, 2022 09:11
Member
Author
|
looks like tests pass now |
jbolda
previously approved these changes
Mar 2, 2022
jbolda
left a comment
Member
There was a problem hiding this comment.
I like where you went with the package manager. It was definitely needed. I think switching away from the shorthand pm is a good idea, but the rest are more comments than anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
TODOs:
@tauri-apps/cli?@tauri-apps/cli?