Skip to content

fix: disallow uppercase in package name - #527

Merged
amrbashir merged 1 commit into
devfrom
fix/disallow-uppercase
Nov 13, 2023
Merged

fix: disallow uppercase in package name#527
amrbashir merged 1 commit into
devfrom
fix/disallow-uppercase

Conversation

@amrbashir

Copy link
Copy Markdown
Member

closes #523

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir
amrbashir merged commit 3ca02f5 into dev Nov 13, 2023
@amrbashir
amrbashir deleted the fix/disallow-uppercase branch November 13, 2023 13:28
@FabianLars

FabianLars commented Nov 13, 2023

Copy link
Copy Markdown
Member

Is that only for the name in package.json and cargo.toml? Because tauri.conf's product name does support this (and spaces)

@amrbashir

Copy link
Copy Markdown
Member Author

This affects product name as well but that was the old behavior anyways of CTA, i.e. previously if it had spaces, it would be removed.

@amrbashir

Copy link
Copy Markdown
Member Author

I will open another PR to keep spaces and uppercase in productName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tauri installation process allowing package.json name to include illegal characters

2 participants