feat: add blazor template by AerafalDev · Pull Request #656 · tauri-apps/create-tauri-app

AerafalDev · 2024-04-01T20:57:46Z

add blazor template for create tauri app with blazor

Screen.Recording.-.Made.with.FlexClip.5.webm

…e arguments to the beforeDevCommand

… project and solution

amrbashir

We also need to add a new category in categories.rs file

AerafalDev · 2024-04-03T19:02:57Z

We also need to add a new category in categories.rs file

Does this imply creating a new package manager as well?
Because if I add a new category named CSharp, I end up with Cargo templates.
And since Tauri's CLI cannot be used in C#, I won't have a choice but to use Cargo.
So if I'm not mistaken, I'll create a new package manager named NuGet, but it will use Cargo?

Regarding the rest, everything is finished, only this point needs to be clarified.

amrbashir · 2024-04-03T19:14:09Z

Does this imply creating a new package manager as well?
Because if I add a new category named CSharp, I end up with Cargo templates.
And since Tauri's CLI cannot be used in C#, I won't have a choice but to use Cargo.
So if I'm not mistaken, I'll create a new package manager named NuGet, but it will use Cargo?

yeah it is a bit weird, let's go with .NET as the category name and .NET CLI as the package manager name.

Ideally we would publish the Tauri CLI to NuGet and users can call it using dotnet tool run tauri, is that even possible?

AerafalDev · 2024-04-03T19:29:30Z

yeah it is a bit weird, let's go with .NET as the category name and .NET CLI as the package manager name.

Ideally we would publish the Tauri CLI to NuGet and users can call it using dotnet tool run tauri, is that even possible?

Yes this is possible, I'm going to do a poc, before that, what commands are required? Just the command to launch Tauri?

amrbashir · 2024-04-03T19:30:36Z

It should be able to run any tauri subcommand tauri dev, tauri build, tauri info...etc

AerafalDev · 2024-04-03T19:33:07Z

It should be able to run any tauri subcommand tauri dev, tauri build, tauri info...etc

Alright, I just have to make a wrapper, which will implicitly call cargo in this case

amrbashir · 2024-04-03T19:52:46Z

It should be able to run any tauri subcommand tauri dev, tauri build, tauri info...etc

Alright, I just have to make a wrapper, which will implicitly call cargo in this case

No need for a wrapper, I was wondering if it is possible, we could publish tauri-cli to NuGet and then this template could include it as a dependency

AerafalDev · 2024-04-03T19:57:43Z

No need for a wrapper, I was wondering if it is possible, we could publish tauri-cli to NuGet and then this template could include it as a dependency

publish tauri-cli on Nuget? But tauri-cli is made in rust, isn't it?

amrbashir · 2024-04-03T23:21:23Z

yeah, can't we publish a prebuilt binary there?

amrbashir · 2024-04-03T23:22:01Z

anyways, let's just add these categories for now and we can see about publishing tauri-cli to nuget later.

amrbashir · 2024-04-03T23:23:25Z

also make sure to update https://github.com/tauri-apps/create-tauri-app/blob/dev/.scripts/generate-templates-matrix.js and https://github.com/tauri-apps/create-tauri-app/blob/dev/.github/workflows/templates-test.yml so the new template can be tested in CI

amrbashir · 2024-04-04T00:59:48Z

I have a problem when building the job with the ci, the '-' character of 'tauri-app' is not supported in C# uses

then we need to replace with a supported character it in these places

… test github action

zenitogr

Looks good, but, is there a bundler for tauri? I think using withGlobalTauri is not for release, excuse if this is incorrect i am a new dev myself

AerafalDev · 2024-04-04T12:56:17Z

https://github.com/jimmy-mll/create-tauri-app/actions/runs/8554756333

@amrbashir

amrbashir · 2024-04-05T00:00:37Z

looks like you need to run pnpm format and cargo fmt

AerafalDev · 2024-04-05T10:02:02Z

looks like you need to run pnpm format and cargo fmt

👍

…d templates

AerafalDev · 2024-04-05T20:41:07Z

It's all good for me, I think we're not too bad here @amrbashir

amrbashir

Sorry for the delay, I left a few final comments and this should be ready to go.

amrbashir · 2024-04-08T20:38:04Z

+        working-directory: ${{ (matrix.settings.manager == 'dotnet') && 'TauriApp' || 'tauri-app' }}

      - run: ${{ matrix.settings.install_cmd }}
        if: matrix.settings.install_cmd  != ''
-        working-directory: tauri-app
+        working-directory: ${{ (matrix.settings.manager == 'dotnet') && 'TauriApp' || 'tauri-app' }}

      - run: ${{ matrix.settings.run_cmd }} tauri build ${{ matrix.settings.no_bundle_flag }}
        if: matrix.settings.manager != 'npm'
-        working-directory: tauri-app
+        working-directory: ${{ (matrix.settings.manager == 'dotnet') && 'TauriApp' || 'tauri-app' }}


when bootstrapping a dotnet project it should support tauri-app too, we shouldn't handle it here at all, we just need to convert tauri-app to TauriApp automatically in in the template in the files that require it to be without -, I guess for example that would be Program.cs.lte, and in that file we change {% project_name %} to {% project_name_upper_case %}. We will need to inject that variable into the template data though.

amrbashir · 2024-04-08T20:41:02Z

@@ -0,0 +1,11 @@
+using Microsoft.AspNetCore.Components.Web;
+using Microsoft.AspNetCore.Components.WebAssembly.Hosting;
+using {% project_name %};


I think this one

Suggested change

using {% project_name %};

using {% project_name_uppercase %};

amrbashir · 2024-04-08T20:41:36Z

+@using Microsoft.AspNetCore.Components.Web.Virtualization
+@using Microsoft.AspNetCore.Components.WebAssembly.Http
+@using Microsoft.JSInterop
+@using {% project_name %}


and this one

Suggested change

@using {% project_name %}

@using {% project_name_uppercase %}

amrbashir · 2024-04-08T20:41:56Z

and the name of this file

…curences in the blazor template

AerafalDev · 2024-04-09T18:17:36Z

Normally, this time, it’s the right one @amrbashir
https://github.com/jimmy-mll/create-tauri-app/actions/runs/8620215358/job/23626733542

AerafalDev added 7 commits April 1, 2024 22:46

feat: add dotnet dependency

768734b

feat: add blazor template

d8ea964

feat: add blazor template to cargo package manager

9d216d6

feat: implement a method to initiate blazor wasm project creation

c555faf

fix: _gitignore to .gitignore

478aeae

fix: remove the generated launchSettings.json file and add appropriat…

72e1334

…e arguments to the beforeDevCommand

feat: update project creation process for creating blazor webassembly…

96bb2a4

… project and solution

amrbashir requested changes Apr 2, 2024

View reviewed changes

Comment thread src/lib.rs Outdated

AerafalDev requested a review from amrbashir April 2, 2024 19:49

AerafalDev added 3 commits April 3, 2024 19:39

fix: remove dotnet webassembly project creation manually

d8516de

feat: add blazor webassembly generated template

10a10f2

feat: render csproj file name with lte::render

5eac7d1

AerafalDev requested review from Aerafaal and zenitogr April 3, 2024 18:00

amrbashir requested changes Apr 3, 2024

View reviewed changes

AerafalDev requested a review from amrbashir April 3, 2024 19:03

AerafalDev added 4 commits April 3, 2024 21:06

fix: remove favicon & change title

08c82ac

fix: remove favicon & tauri svg

a97b3c9

fix: remove css included by default

2d2437f

fix: add files to copy

04c3bd3

AerafalDev added 5 commits April 4, 2024 14:06

fix: change name of the app if package manager is dotnet in templates…

ae236c2

… test github action

fix: change name of the app if package manager is dotnet in templates…

9ed2ac6

… test github action

fix: syntax error

a9977a8

fix: bump actions/setup-dotnet from v3 to v4

85023c4

fix: remove implicit installed packages

3fa1c2e

zenitogr suggested changes Apr 4, 2024

View reviewed changes

fix: remove useless indentation

e9ffacb

Aerafaal approved these changes Apr 4, 2024

View reviewed changes

style: fomat code

d6a53b7

AerafalDev added 2 commits April 5, 2024 12:58

fix: package manager from template

27b1dc7

fix: update README.md and add blazor template to currently supporte…

2d0829a

…d templates

amrbashir requested changes Apr 8, 2024

View reviewed changes

AerafalDev added 4 commits April 9, 2024 19:45

feat: add pascal case project name in template data and rename all oc…

66649b1

…curences in the blazor template

fix: remove conditionnal name for dotnet package manager

bd55a5a

fix: add project_name_pascal_case to manifest data

b668878

fix: handle snake_case and kebab-case

a9a2e02

AerafalDev requested a review from amrbashir April 18, 2024 16:21

amrbashir previously approved these changes Apr 23, 2024

View reviewed changes

change file [skip ci]

74eda2b

amrbashir dismissed their stale review via 74eda2b April 23, 2024 02:43

amrbashir approved these changes Apr 23, 2024

View reviewed changes

amrbashir changed the title ~~add blazor template~~ feat: add blazor template Apr 23, 2024

amrbashir merged commit 4edb69f into tauri-apps:dev Apr 23, 2024

AerafalDev deleted the blazor branch April 23, 2024 08:00

	using {% project_name %};
	using {% project_name_uppercase %};

	@using {% project_name %}
	@using {% project_name_uppercase %}

Uh oh!

Conversation

AerafalDev commented Apr 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

amrbashir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AerafalDev commented Apr 3, 2024

Uh oh!

amrbashir commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AerafalDev commented Apr 3, 2024

Uh oh!

amrbashir commented Apr 3, 2024

Uh oh!

AerafalDev commented Apr 3, 2024

Uh oh!

amrbashir commented Apr 3, 2024

Uh oh!

AerafalDev commented Apr 3, 2024

Uh oh!

amrbashir commented Apr 3, 2024

Uh oh!

amrbashir commented Apr 3, 2024

Uh oh!

amrbashir commented Apr 3, 2024

Uh oh!

amrbashir commented Apr 4, 2024

Uh oh!

zenitogr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AerafalDev commented Apr 4, 2024

Uh oh!

amrbashir commented Apr 5, 2024

Uh oh!

AerafalDev commented Apr 5, 2024

Uh oh!

AerafalDev commented Apr 5, 2024

Uh oh!

amrbashir left a comment

Choose a reason for hiding this comment

Uh oh!

amrbashir Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

amrbashir Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

amrbashir Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

amrbashir Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

AerafalDev commented Apr 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AerafalDev commented Apr 1, 2024 •

edited

Loading

amrbashir commented Apr 3, 2024 •

edited

Loading

zenitogr left a comment •

edited

Loading