fix(templates): add node:process import for deno in vite config templates - #960
FabianLars merged 5 commits into
Conversation
|
i think we can add the import for node users as well though we may want to annotate it something like this then we can use the ts-expect-error on the const host line and your deno arg |
|
p.s. no idea why ci has been failing today in all prs. can take a look later. |
|
@FabianLars I've updated the templates as follows:
|
Does it cause issues if we have the ts error in the deno version? I'd love to get rid of deno specific stuff here to keep it simple. |
|
|
No i meant this line because if it's just ignored and the import is the same for both node and deno i'd just have that line in both cases so we can get rid of the if/else |
|
@FabianLars |
|
yes that's what i meant! Sorry for me being difficult. |
|
ah sorry, can you also add a changefile like in the other pr? |
Added! |
|
thanks! |
node:process import for deno in vite config templatesnode:process import for deno in vite config templates

When using Deno as the runtime, accessing
processas a global triggers:This adds the explicit import conditionally when Deno is selected as the package manager.