Skip to content

Commit 052e8b4

Browse files
fix(cli): Downgrade minisign to 0.7.3 once again (#8838)
* fix(cli): Downgrade minisign to 0.7.3 once again * add tests * add change file --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
1 parent e52d5e5 commit 052e8b4

4 files changed

Lines changed: 25 additions & 3 deletions

File tree

.changes/downgrade-minisign.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"tauri-cli": patch:bug
3+
"@tauri-apps/cli": patch:bug
4+
---
5+
6+
Downgrade minisign dependency fixing updater signing key bug and prevent it from happening in the future.

tooling/cli/Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tooling/cli/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ toml = "0.8"
6565
jsonschema = "0.17"
6666
handlebars = "5.0"
6767
include_dir = "0.7"
68-
minisign = "=0.7.5"
68+
minisign = "=0.7.3"
6969
base64 = "0.21.5"
7070
ureq = { version = "2.8", default-features = false, features = [ "gzip" ] }
7171
os_info = "3"

tooling/cli/src/helpers/updater_signature.rs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,3 +160,19 @@ where
160160
.map_err(|e| minisign::PError::new(minisign::ErrorKind::Io, e))?;
161161
Ok(BufReader::new(file))
162162
}
163+
164+
#[cfg(test)]
165+
mod tests {
166+
const PRIVATE_KEY: &str = "dW50cnVzdGVkIGNvbW1lbnQ6IHJzaWduIGVuY3J5cHRlZCBzZWNyZXQga2V5ClJXUlRZMEl5dkpDN09RZm5GeVAzc2RuYlNzWVVJelJRQnNIV2JUcGVXZUplWXZXYXpqUUFBQkFBQUFBQUFBQUFBQUlBQUFBQTZrN2RnWGh5dURxSzZiL1ZQSDdNcktiaHRxczQwMXdQelRHbjRNcGVlY1BLMTBxR2dpa3I3dDE1UTVDRDE4MXR4WlQwa1BQaXdxKy9UU2J2QmVSNXhOQWFDeG1GSVllbUNpTGJQRkhhTnROR3I5RmdUZi90OGtvaGhJS1ZTcjdZU0NyYzhQWlQ5cGM9Cg==";
167+
168+
// we use minisign=0.7.3 to prevent a breaking change
169+
#[test]
170+
fn empty_password_is_valid() {
171+
let path = std::env::temp_dir().join("minisign-password-text.txt");
172+
std::fs::write(&path, b"TAURI").expect("failed to write test file");
173+
174+
let secret_key =
175+
super::secret_key(PRIVATE_KEY, Some("".into())).expect("failed to resolve secret key");
176+
super::sign_file(&secret_key, &path).expect("failed to sign file");
177+
}
178+
}

0 commit comments

Comments
 (0)