refactor: put dynamic acl to a feature (#13418)

* refactor: put dynamic acl to a feature

* Add change file

* Tweak remove_unused_commands's docs

* License header

* Document the feature

* Merge remote-tracking branch 'upstream/dev' into dynamic-acl-feature

* Use a inner non generic fn for add_capability

* Clippy and macro stability notice

* Merge remote-tracking branch 'upstream/dev' into dynamic-acl-feature

* Format

Author: Legend-Master

.changes/dynamic-acl-feature.md

@@ -0,0 +1,7 @@
+---
+"tauri": 'minor:changes'
+"tauri-codegen": 'minor:changes'
+"tauri-utils": 'minor:changes'
+---
+
+Put dynamic ACL into a feature `dynamic-acl`, this is currently enabled by default to align with the previous behaviors, you can disable it through `default-features = false` to reduce the final binary size by not including the ACL references

Cargo.lock

@@ -1873,7 +1873,7 @@
           }
         },
         "removeUnusedCommands": {
-          "description": "Try to remove unused commands registered from plugins base on the ACL list during `tauri build`,\n the way it works is that tauri-cli will read this and set the environment variables for the build script and macros,\n and they'll try to get all the allowed commands and remove the rest\n\n Note:\n   - This won't be accounting for dynamically added ACLs so make sure to check it when using this\n   - This feature requires tauri-plugin 2.1 and tauri 2.4",
+          "description": "Try to remove unused commands registered from plugins base on the ACL list during `tauri build`,\n the way it works is that tauri-cli will read this and set the environment variables for the build script and macros,\n and they'll try to get all the allowed commands and remove the rest\n\n Note:\n   - This won't be accounting for dynamically added ACLs when you use features from the `dynamic-acl` (currently enabled by default) feature flag, so make sure to check it when using this\n   - This feature requires tauri-plugin 2.1 and tauri 2.4",
           "default": false,
           "type": "boolean"
         }

crates/tauri-cli/config.schema.json

@@ -60,6 +60,7 @@ pub struct Options {
   ios_color: String,
 }
 
+#[allow(clippy::large_enum_variant)]
 enum Source {
   Svg(resvg::usvg::Tree),
   DynamicImage(DynamicImage),

crates/tauri-cli/src/icon.rs

@@ -1103,7 +1103,7 @@ impl RustAppSettings {
             .to_string()
         })
     });
-    let target = TargetPlatform::from_triple(&target_triple);
+    let target_platform = TargetPlatform::from_triple(&target_triple);
 
     Ok(Self {
       manifest: Mutex::new(manifest),
@@ -1113,7 +1113,7 @@ impl RustAppSettings {
       package_settings,
       cargo_config,
       target_triple,
-      target_platform: target,
+      target_platform,
     })
   }
 

crates/tauri-cli/src/interface/rust.rs

@@ -409,7 +409,8 @@ pub fn context_codegen(data: ContextData) -> EmbeddedAssetsResult<TokenStream> {
     identity,
   );
 
-  let runtime_authority = quote!(#root::ipc::RuntimeAuthority::new(#acl_tokens, #resolved));
+  let runtime_authority =
+    quote!(#root::runtime_acl!(#root::ipc::RuntimeAuthority::new, #acl_tokens, #resolved));
 
   let plugin_global_api_scripts = if config.app.with_global_tauri {
     if let Some(scripts) = tauri_utils::plugin::read_global_api_scripts(&out_dir) {

crates/tauri-codegen/src/context.rs

@@ -263,10 +263,7 @@ fn assert_command(
   let status =
     response.map_err(|e| std::io::Error::new(e.kind(), format!("{error_message}: {e}")))?;
   if !status.success() {
-    Err(std::io::Error::new(
-      std::io::ErrorKind::Other,
-      error_message,
-    ))
+    Err(std::io::Error::other(error_message))
   } else {
     Ok(())
   }

crates/tauri-macos-sign/src/lib.rs

@@ -18,6 +18,7 @@ use syn::{
 };
 use tauri_utils::acl::REMOVE_UNUSED_COMMANDS_ENV_VAR;
 
+#[allow(clippy::large_enum_variant)]
 enum WrapperAttributeKind {
   Meta(Meta),
   Async,

crates/tauri-macros/src/command/wrapper.rs

@@ -972,7 +972,6 @@ impl WindowBuilder for WindowBuilderWrapper {
   /// ## Platform-specific
   ///
   /// - **iOS / Android:** Unsupported.
-  #[must_use]
   fn prevent_overflow(mut self) -> Self {
     self
       .prevent_overflow
@@ -986,7 +985,6 @@ impl WindowBuilder for WindowBuilderWrapper {
   /// ## Platform-specific
   ///
   /// - **iOS / Android:** Unsupported.
-  #[must_use]
   fn prevent_overflow_with_margin(mut self, margin: Size) -> Self {
     self.prevent_overflow.replace(margin);
     self

crates/tauri-runtime-wry/src/lib.rs

@@ -1873,7 +1873,7 @@
           }
         },
         "removeUnusedCommands": {
-          "description": "Try to remove unused commands registered from plugins base on the ACL list during `tauri build`,\n the way it works is that tauri-cli will read this and set the environment variables for the build script and macros,\n and they'll try to get all the allowed commands and remove the rest\n\n Note:\n   - This won't be accounting for dynamically added ACLs so make sure to check it when using this\n   - This feature requires tauri-plugin 2.1 and tauri 2.4",
+          "description": "Try to remove unused commands registered from plugins base on the ACL list during `tauri build`,\n the way it works is that tauri-cli will read this and set the environment variables for the build script and macros,\n and they'll try to get all the allowed commands and remove the rest\n\n Note:\n   - This won't be accounting for dynamically added ACLs when you use features from the `dynamic-acl` (currently enabled by default) feature flag, so make sure to check it when using this\n   - This feature requires tauri-plugin 2.1 and tauri 2.4",
           "default": false,
           "type": "boolean"
         }