fix(cli): adb reverse failing in Node.js (#10466)

tauri-apps · Aug 3, 2024 · 206914f · 206914f
1 parent 005e4a9
commit 206914f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changes/fix-adb.md b/.changes/fix-adb.md
@@ -0,0 +1,6 @@
+---
+"tauri-cli": patch:bug
+"@tauri-apps/cli": patch:bug
+---
+
+Fixes running `adb reverse` in Node.js context.
diff --git a/tooling/cli/src/mobile/android/dev.rs b/tooling/cli/src/mobile/android/dev.rs
@@ -218,7 +218,11 @@ fn run_dev(
     .clone();
   if let Some(port) = dev_url.and_then(|url| url.port_or_known_default()) {
     let forward = format!("tcp:{port}");
-    adb::adb(&env, ["reverse", &forward, &forward]).run()?;
+    adb::adb(&env, ["reverse", &forward, &forward])
+      .stdin_file(os_pipe::dup_stdin().unwrap())
+      .stdout_file(os_pipe::dup_stdout().unwrap())
+      .stderr_capture()
+      .run()?;
   }
 
   let open = options.open;