fix(core): updater not replacing variables, closes #3428 (#3432)

Author: lucasfernog

.changes/fix-updater-percent-decode.md

@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+Fixes an issue with the updater when replacing the `{{target}}` and `{{current_version}}` variables due to percent-encoding on the `Url` that is parsed from the configuration.

core/tauri/src/updater/core.rs

@@ -199,15 +199,23 @@ impl<'a> UpdateBuilder<'a> {
 
   #[allow(dead_code)]
   pub fn url(mut self, url: String) -> Self {
-    self.urls.push(url);
+    self.urls.push(
+      percent_encoding::percent_decode(url.as_bytes())
+        .decode_utf8_lossy()
+        .to_string(),
+    );
     self
   }
 
   /// Add multiple URLS at once inside a Vec for future reference
   pub fn urls(mut self, urls: &[String]) -> Self {
     let mut formatted_vec: Vec<String> = Vec::new();
     for url in urls {
-      formatted_vec.push(url.to_owned());
+      formatted_vec.push(
+        percent_encoding::percent_decode(url.as_bytes())
+          .decode_utf8_lossy()
+          .to_string(),
+      );
     }
     self.urls = formatted_vec;
     self
@@ -963,6 +971,51 @@ mod test {
     assert!(updater.should_update);
   }
 
+  #[test]
+  fn simple_http_updater_percent_decode() {
+    let _m = mockito::mock("GET", "/darwin/1.0.0")
+      .with_status(200)
+      .with_header("content-type", "application/json")
+      .with_body(generate_sample_platform_json(
+        "2.0.0",
+        "SampleTauriKey",
+        "https://tauri.studio",
+      ))
+      .create();
+
+    let check_update = block!(builder(Default::default())
+      .current_version("1.0.0")
+      .url(
+        url::Url::parse(&format!(
+          "{}/darwin/{{{{current_version}}}}",
+          mockito::server_url()
+        ))
+        .unwrap()
+        .to_string()
+      )
+      .build());
+
+    assert!(check_update.is_ok());
+    let updater = check_update.expect("Can't check update");
+
+    assert!(updater.should_update);
+
+    let check_update = block!(builder(Default::default())
+      .current_version("1.0.0")
+      .urls(&[url::Url::parse(&format!(
+        "{}/darwin/{{{{current_version}}}}",
+        mockito::server_url()
+      ))
+      .unwrap()
+      .to_string()])
+      .build());
+
+    assert!(check_update.is_ok());
+    let updater = check_update.expect("Can't check update");
+
+    assert!(updater.should_update);
+  }
+
   #[test]
   fn simple_http_updater_with_elevated_task() {
     let _m = mockito::mock("GET", "/win64/1.0.0")