feat(cli) rewrite the core CLI in Rust (#851)

Author: lucasfernog

.changes/cli-rust.md

@@ -0,0 +1,6 @@
+---
+"tauri-cli": minor
+"tauri-bundler": minor
+---
+
+The `dev` and `build` pipeline is now written in Rust.

.changes/config.json

@@ -139,21 +139,36 @@
     }
   },
   "packages": {
-    "tauri.js": {
-      "path": "./cli/tauri.js",
+    "api": {
+      "path": "./api",
       "manager": "javascript",
-      "dependencies": ["tauri"],
       "assets": [
         {
-          "path": "./cli/tauri.js/tauri-${ pkgFile.version }.tgz",
-          "name": "tauri.js-${ pkgFile.version }.tgz"
+          "path": "./api/tauri-${ pkgFile.version }.tgz",
+          "name": "api-${ pkgFile.version }.tgz"
         }
       ]
     },
     "tauri-bundler": {
       "path": "./cli/tauri-bundler",
       "manager": "rust"
     },
+    "tauri-cli": {
+      "path": "./cli/core",
+      "manager": "rust",
+      "dependencies": ["api", "tauri-bundler", "tauri"]
+    },
+    "tauri.js": {
+      "path": "./cli/tauri.js",
+      "manager": "javascript",
+      "dependencies": ["tauri-cli"],
+      "assets": [
+        {
+          "path": "./cli/tauri.js/tauri-${ pkgFile.version }.tgz",
+          "name": "tauri.js-${ pkgFile.version }.tgz"
+        }
+      ]
+    },
     "tauri-utils": {
       "path": "./tauri-utils",
       "manager": "rust"
@@ -171,7 +186,7 @@
     "tauri": {
       "path": "./tauri",
       "manager": "rust",
-      "dependencies": ["tauri-api", "tauri-updater"]
+      "dependencies": ["api", "tauri-api", "tauri-updater"]
     }
   }
 }

.changes/tauri-api.md

@@ -0,0 +1,8 @@
+---
+"tauri.js": minor
+---
+
+The Tauri API interface is now shipped with the `@tauri-apps/api` package instead of the deprecated `tauri` package.
+To use the new API package, delete the old `tauri` from your `package.json` and install the new package:
+`$ yarn remove tauri && yarn add @tauri-apps/api` or `$ npm uninstall tauri && npm install @tauri-apps/api`.
+And change all `import { someApi } from 'tauri/api` to `import { someApi } from '@tauri-apps/api'`.

.changes/tauri-cli.md

@@ -0,0 +1,7 @@
+---
+"tauri.js": minor
+---
+
+The Tauri Node.js CLI package is now `@tauri-apps/cli`.
+To use the new CLI, delete the old `tauri` from your `package.json` and install the new package:
+`$ yarn remove tauri && yarn add --dev @tauri-apps/cli` or `$ npm uninstall tauri && npm install --save-dev @tauri-apps/cli`.

.github/CODEOWNERS

@@ -15,6 +15,8 @@
 
 /cli/tauri-bundler/ @tauri-apps/bundler
 
+/cli/core/ @tauri-apps/core
+
 /cli/tauri.js/ @tauri-apps/js-cli
 
 /tauri-update/ @tauri-apps/core

.github/workflows/core-lint-fmt.yml

@@ -7,6 +7,7 @@ on:
       - 'tauri/**'
       - 'tauri-utils/**'
       - 'tauri-api/**'
+      - 'cli/core/**'
 
 jobs:
   workspace_clippy_fmt_check:
@@ -38,6 +39,28 @@ jobs:
           command: fmt
           args: --all -- --check
 
+  cli_clippy_fmt_check:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - run: rustup component add clippy
+      - uses: actions-rs/clippy-check@v1
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          args: --manifest-path ./cli/core/Cargo.toml --all-targets -- -D warnings
+          name: cli
+      - uses: actions-rs/toolchain@v1
+        with:
+            profile: minimal
+            toolchain: nightly
+            override: true
+            components: rustfmt
+      - uses: actions-rs/cargo@v1
+        with:
+          command: fmt
+          args: --manifest-path ./cli/core/Cargo.toml --all -- --check
+
   core_clippy_check:
     runs-on: ubuntu-latest
     strategy:

.github/workflows/test-core.yml

@@ -46,6 +46,30 @@ jobs:
           TAURI_DIST_DIR: ${{ runner.workspace }}/tauri/tauri/examples/communication/dist
           TAURI_DIR: ${{ runner.workspace }}/tauri/tauri/examples/communication/src-tauri
 
+  test-tauri-cli:
+    runs-on: ${{ matrix.platform }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        platform: [ubuntu-latest, macos-latest, windows-latest]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: install stable
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+      - name: build api
+        working-directory: ./api
+        run: yarn && yarn build
+      - name: build CLI
+        uses: actions-rs/cargo@v1
+        with:
+          command: build
+          args: --manifest-path ./cli/core/Cargo.toml
+
   test-tauri-js-cli:
     runs-on: ${{ matrix.platform }}
 
@@ -61,9 +85,8 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y webkit2gtk-4.0
-      - run: cargo install --path ./cli/tauri-bundler --force
       - name: test
-        timeout-minutes: 15
+        timeout-minutes: 30
         run: |
           cd ./cli/tauri.js
           yarn

.gitignore

@@ -76,7 +76,7 @@ TODO.md
 target
 
 # lock for libs
-Cargo.lock
+/Cargo.lock
 yarn.lock
 
 /cli/tauri.js/test/jest/tmp

api/.eslintignore

@@ -0,0 +1 @@
+/src/types/config.validator.ts

api/.eslintrc.js

@@ -0,0 +1,56 @@
+module.exports = {
+  root: true,
+
+  env: {
+    node: true,
+    jest: true,
+  },
+
+  parser: "@typescript-eslint/parser",
+
+  extends: [
+    "standard-with-typescript",
+    "plugin:@typescript-eslint/recommended-requiring-type-checking",
+    "plugin:lodash-template/recommended",
+    // TODO: make this work with typescript
+    // 'plugin:node/recommended'
+    "prettier",
+    "prettier/@typescript-eslint",
+  ],
+
+  plugins: ["@typescript-eslint", "node", "security"],
+
+  parserOptions: {
+    tsconfigRootDir: __dirname,
+    project: "./tsconfig.json",
+  },
+
+  globals: {
+    __statics: true,
+    process: true,
+  },
+
+  // add your custom rules here
+  rules: {
+    // allow console.log during development only
+    "no-console": process.env.NODE_ENV === "production" ? "error" : "off",
+    // allow debugger during development only
+    "no-debugger": process.env.NODE_ENV === "production" ? "error" : "off",
+    "no-process-exit": "off",
+    "security/detect-non-literal-fs-filename": "warn",
+    "security/detect-unsafe-regex": "error",
+    "security/detect-buffer-noassert": "error",
+    "security/detect-child-process": "warn",
+    "security/detect-disable-mustache-escape": "error",
+    "security/detect-eval-with-expression": "error",
+    "security/detect-no-csrf-before-method-override": "error",
+    "security/detect-non-literal-regexp": "error",
+    "security/detect-non-literal-require": "warn",
+    "security/detect-object-injection": "warn",
+    "security/detect-possible-timing-attacks": "error",
+    "security/detect-pseudoRandomBytes": "error",
+    "space-before-function-paren": "off",
+    "@typescript-eslint/default-param-last": "off",
+    "@typescript-eslint/strict-boolean-expressions": 0,
+  },
+};