Skip to content

Commit 757e959

Browse files
authored
feat: respect base tag's target attribute, closes #7285 (#7344)
* feat: respect `base` tag's `target` attribute, closes #7285 * Update core.js * fix condition
1 parent fa7f9b7 commit 757e959

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

.changes/core-base-links-target.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'tauri': 'minor:enhance'
3+
---
4+
5+
Open links externally when `<base target="_blank" />` exists

core/tauri/scripts/core.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,14 @@
9191
document.querySelector('body').addEventListener(
9292
'click',
9393
function (e) {
94-
var target = e.target
94+
let target = e.target
95+
const baseTarget = document.querySelector('head base')?.target
9596
while (target != null) {
9697
if (target.matches('a')) {
9798
if (
9899
target.href &&
99100
(['http://', 'https://', 'mailto:', 'tel:'].some(v => target.href.startsWith(v))) &&
100-
target.target === '_blank'
101+
(target.target === '_blank' || (!target.target && baseTarget === "_blank"))
101102
) {
102103
window.__TAURI_INVOKE__('tauri', {
103104
__tauriModule: 'Shell',

0 commit comments

Comments
 (0)