Skip to content

Commit

Permalink
feat(cli): improve error message when dev runner command fails (#3447)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucasfernog authored Feb 13, 2022
1 parent 8d0d4f2 commit 759d1af
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
6 changes: 6 additions & 0 deletions .changes/cli-runner-error-message.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"cli.rs": patch
"cli.js": patch
---

Improve error message when the dev runner command fails.
10 changes: 5 additions & 5 deletions tooling/cli/src/dev.rs
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ pub fn command(options: Options) -> Result<()> {
}
}

let mut process = start_app(&options, &runner, &cargo_features, child_wait_rx.clone());
let mut process = start_app(&options, &runner, &cargo_features, child_wait_rx.clone())?;

let (tx, rx) = channel();

Expand Down Expand Up @@ -268,7 +268,7 @@ pub fn command(options: Options) -> Result<()> {
break;
}
}
process = start_app(&options, &runner, &cargo_features, child_wait_rx.clone());
process = start_app(&options, &runner, &cargo_features, child_wait_rx.clone())?;
}
}
}
Expand Down Expand Up @@ -298,7 +298,7 @@ fn start_app(
runner: &str,
features: &[String],
child_wait_rx: Arc<Mutex<Receiver<()>>>,
) -> Arc<SharedChild> {
) -> Result<Arc<SharedChild>> {
let mut command = Command::new(runner);
command.args(&["run", "--no-default-features"]);

Expand All @@ -321,7 +321,7 @@ fn start_app(
command.pipe().unwrap();

let child =
SharedChild::spawn(&mut command).unwrap_or_else(|_| panic!("failed to run {}", runner));
SharedChild::spawn(&mut command).with_context(|| format!("failed to run {}", runner))?;
let child_arc = Arc::new(child);

let child_clone = child_arc.clone();
Expand Down Expand Up @@ -349,5 +349,5 @@ fn start_app(
}
});

child_arc
Ok(child_arc)
}

0 comments on commit 759d1af

Please sign in to comment.