fix(bundler): unset NSISDIR and NSISCONFDIR when running `makensi…

…s` (#8376) closes #8359
tauri-apps · Dec 12, 2023 · 777ddf4 · 777ddf4
1 parent 327c7ae
commit 777ddf4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changes/bundler-nsis-nsisdir.md b/.changes/bundler-nsis-nsisdir.md
@@ -0,0 +1,5 @@
+---
+'tauri-bundler': 'patch:bug'
+---
+
+Unset `NSISDIR` and `NSISCONFDIR` when running `makensis.exe` so it doesn't conflict with NSIS installed by the user.
diff --git a/tooling/bundler/src/bundle/windows/nsis.rs b/tooling/bundler/src/bundle/windows/nsis.rs
@@ -457,6 +457,8 @@ fn build_nsis_app_installer(
       _ => "-V4",
     })
     .arg(installer_nsi_path)
+    .env_remove("NSISDIR")
+    .env_remove("NSISCONFDIR")
     .current_dir(output_path)
     .piped()
     .context("error running makensis.exe")?;