Skip to content

Commit 7eb1171

Browse files
authored
fix(bundler/wix): use product name to generate UpgradeCode for MSI (#10967)
The upgrade code generation was changed due to an accidental regression in #9375. Previously `UpgradeCode` was calculated using the main binary name which was `<product_name>.exe`, but #9375 changed the default main binary name to `<cargo-crate-name>.exe` and thus a different UpgradeCode was generetad. This PR reverts this change to use product name for `UpgradeCode` generation.
1 parent 6566182 commit 7eb1171

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"tauri-bundler": "patch:bug"
3+
---
4+
5+
Fix generated `UpgradeCode` for MSI not matching MSI installers created with tauri-bundler@v1.

crates/tauri-bundler/src/bundle/windows/msi/wix.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ pub fn build_wix_app_installer(
524524
data.insert("manufacturer", to_json(manufacturer));
525525
let upgrade_code = Uuid::new_v5(
526526
&Uuid::NAMESPACE_DNS,
527-
format!("{}.app.x64", &settings.main_binary_name()).as_bytes(),
527+
format!("{}.exe.app.x64", &settings.product_name()).as_bytes(),
528528
)
529529
.to_string();
530530

0 commit comments

Comments
 (0)