Skip to content

Commit

Permalink
fix(bundler/wix): use product name to generate UpgradeCode for MSI (#…
Browse files Browse the repository at this point in the history
…10967)

The upgrade code generation was changed due to an accidental regression in #9375. Previously `UpgradeCode` was calculated using the main binary name which was `<product_name>.exe`, but #9375 changed the default main binary name to `<cargo-crate-name>.exe` and thus a different UpgradeCode was generetad.

This PR reverts this change to use product name for `UpgradeCode` generation.
  • Loading branch information
amrbashir authored Sep 12, 2024
1 parent 6566182 commit 7eb1171
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changes/wix-upgrade-code-regression.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"tauri-bundler": "patch:bug"
---

Fix generated `UpgradeCode` for MSI not matching MSI installers created with tauri-bundler@v1.
2 changes: 1 addition & 1 deletion crates/tauri-bundler/src/bundle/windows/msi/wix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ pub fn build_wix_app_installer(
data.insert("manufacturer", to_json(manufacturer));
let upgrade_code = Uuid::new_v5(
&Uuid::NAMESPACE_DNS,
format!("{}.app.x64", &settings.main_binary_name()).as_bytes(),
format!("{}.exe.app.x64", &settings.product_name()).as_bytes(),
)
.to_string();

Expand Down

0 comments on commit 7eb1171

Please sign in to comment.