Skip to content

Commit 85de230

Browse files
authored
fix(core): race between drop old JS listeners and create new listeners on page load (#9144)
* fix(core): race between drop old JS listeners and create new listeners on page load * Create fix-js-unlisten-all-race.md
1 parent c3ea3a2 commit 85de230

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"tauri": patch:bug
3+
---
4+
5+
Fix old JS listeners being dropped on page load after it was possible to create new listeners.

core/tauri/src/webview/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ tauri::Builder::default()
571571
.on_page_load_handler
572572
.replace(Box::new(move |url, event| {
573573
if let Some(w) = manager_.get_webview(&label_) {
574-
if let PageLoadEvent::Finished = event {
574+
if let PageLoadEvent::Started = event {
575575
w.unlisten_all_js();
576576
}
577577
if let Some(handler) = self.on_page_load_handler.as_ref() {

0 commit comments

Comments
 (0)