Skip to content

Commit 8e1daad

Browse files
authored
fix(bundler): set app name when signing MSI, closes #3945 (#3950)
1 parent 25aa434 commit 8e1daad

3 files changed

Lines changed: 8 additions & 0 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"tauri-bundler": patch
3+
---
4+
5+
Set the application name when signing the Windows MSI.

tooling/bundler/src/bundle/windows/msi/wix.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,6 +379,7 @@ pub fn build_wix_app_installer(
379379
sign(
380380
&file_path,
381381
&SignParams {
382+
product_name: settings.product_name().into(),
382383
digest_algorithm: settings
383384
.windows()
384385
.digest_algorithm

tooling/bundler/src/bundle/windows/sign.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ use winreg::{
1515
};
1616

1717
pub struct SignParams {
18+
pub product_name: String,
1819
pub digest_algorithm: String,
1920
pub certificate_thumbprint: String,
2021
pub timestamp_url: Option<String>,
@@ -103,6 +104,7 @@ pub fn sign<P: AsRef<Path>>(path: P, params: &SignParams) -> crate::Result<()> {
103104
cmd.arg("sign");
104105
cmd.args(&["/fd", &params.digest_algorithm]);
105106
cmd.args(&["/sha1", &params.certificate_thumbprint]);
107+
cmd.args(&["/d", &params.product_name]);
106108

107109
if let Some(ref timestamp_url) = params.timestamp_url {
108110
if params.tsp == Some(true) {

0 commit comments

Comments
 (0)