fix(cli/icon): return with an error instead of panic (#9638)

amrbashir · web-flow · commit 97ec422f22d0 · 2024-05-02T13:26:53.000+02:00
* fix(cli/icon): return with an error instead of panic closes #9636 * Update .changes/cli-icon-non-0-exit.md
diff --git a/.changes/cli-icon-non-0-exit.md b/.changes/cli-icon-non-0-exit.md
@@ -0,0 +1,6 @@
+---
+"tauri-cli": "patch:bug"
+"@tauri-apps/cli": "patch:bug"
+---
+
+Exit `tauri icon` with non-zero code when it fails.
diff --git a/tooling/cli/src/icon.rs b/tooling/cli/src/icon.rs
@@ -138,11 +138,11 @@ pub fn command(options: Options) -> Result<()> {
       ))
     }
   } else {
-    panic!("Error loading image");
+    anyhow::bail!("Error loading image");
   };
 
   if source.height() != source.width() {
-    panic!("Source image must be square");
+    anyhow::bail!("Source image must be square");
   }
 
   if png_icon_sizes.is_empty() {

Original file line number	Diff line number	Diff line change
`@@ -138,11 +138,11 @@ pub fn command(options: Options) -> Result<()> {`
`138`	`138`	`))`
`139`	`139`	`}`
`140`	`140`	`} else {`
`141`		`- panic!("Error loading image");`
	`141`	`+ anyhow::bail!("Error loading image");`
`142`	`142`	`};`
`143`	`143`
`144`	`144`	`if source.height() != source.width() {`
`145`		`- panic!("Source image must be square");`
	`145`	`+ anyhow::bail!("Source image must be square");`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`if png_icon_sizes.is_empty() {`