Skip to content

Commit

Permalink
feat(cli): detect SolidJS and SolidStart (#5758)
Browse files Browse the repository at this point in the history
  • Loading branch information
AR10Dev authored Dec 8, 2022
1 parent b293da3 commit 9e7ce0a
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .changes/add-solid-js-framework.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"cli.rs": patch
"cli.js": patch
---

Detect SolidJS and SolidStart for the init and info commands.
10 changes: 10 additions & 0 deletions tooling/cli/src/helpers/framework.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ use std::fmt;

#[derive(Debug, Clone)]
pub enum Framework {
SolidJS,
SolidStart,
Svelte,
SvelteKit,
Angular,
Expand All @@ -21,6 +23,8 @@ pub enum Framework {
impl Framework {
pub fn dev_path(&self) -> String {
match self {
Self::SolidJS => "http://localhost:3000",
Self::SolidStart => "http://localhost:3000",
Self::Svelte => "http://localhost:8080",
Self::SvelteKit => "http://localhost:5173",
Self::Angular => "http://localhost:4200",
Expand All @@ -37,6 +41,8 @@ impl Framework {

pub fn dist_dir(&self) -> String {
match self {
Self::SolidJS => "../dist",
Self::SolidStart => "../dist/public",
Self::Svelte => "../public",
Self::SvelteKit => "../build",
Self::Angular => "../dist",
Expand All @@ -55,6 +61,8 @@ impl Framework {
impl fmt::Display for Framework {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Self::SolidJS => write!(f, "SolidJS"),
Self::SolidStart => write!(f, "SolidStart"),
Self::Svelte => write!(f, "Svelte"),
Self::SvelteKit => write!(f, "SvelteKit"),
Self::Angular => write!(f, "Angular"),
Expand Down Expand Up @@ -88,6 +96,8 @@ impl fmt::Display for Bundler {

pub fn infer_from_package_json(package_json: &str) -> (Option<Framework>, Option<Bundler>) {
let framework_map = [
("solid-start", Framework::SolidStart, Some(Bundler::Vite)),
("solid-js", Framework::SolidJS, Some(Bundler::Vite)),
("svelte", Framework::Svelte, Some(Bundler::Rollup)),
("@sveltejs/kit", Framework::SvelteKit, Some(Bundler::Vite)),
("@angular", Framework::Angular, Some(Bundler::Webpack)),
Expand Down

0 comments on commit 9e7ce0a

Please sign in to comment.