feat(core): expose message dialog's title option, ref #4183 (#4186)

tauri-apps · May 21, 2022 · ae99f99 · ae99f99
1 parent a7a9fde
commit ae99f99
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 5 deletions.
diff --git a/.changes/expose-message-dialog-title.md b/.changes/expose-message-dialog-title.md
@@ -0,0 +1,6 @@
+---
+"tauri": patch
+"api": patch
+---
+
+Expose `title` option in the message dialog API.
diff --git a/core/tauri/scripts/bundle.js b/core/tauri/scripts/bundle.js
diff --git a/core/tauri/src/endpoints/dialog.rs b/core/tauri/src/endpoints/dialog.rs
@@ -70,7 +70,10 @@ pub enum Cmd {
   #[cmd(dialog_save, "dialog > save")]
   SaveDialog { options: SaveDialogOptions },
   #[cmd(dialog_message, "dialog > message")]
-  MessageDialog { message: String },
+  MessageDialog {
+    title: Option<String>,
+    message: String,
+  },
   #[cmd(dialog_ask, "dialog > ask")]
   AskDialog {
     title: Option<String>,
@@ -168,10 +171,14 @@ impl Cmd {
   }
 
   #[module_command_handler(dialog_message)]
-  fn message_dialog<R: Runtime>(context: InvokeContext<R>, message: String) -> super::Result<()> {
+  fn message_dialog<R: Runtime>(
+    context: InvokeContext<R>,
+    title: Option<String>,
+    message: String,
+  ) -> super::Result<()> {
     crate::api::dialog::blocking::message(
       Some(&context.window),
-      &context.window.app_handle.package_info().name,
+      title.unwrap_or_else(|| context.window.app_handle.package_info().name.clone()),
       message,
     );
     Ok(())

diff --git a/tooling/api/src/dialog.ts b/tooling/api/src/dialog.ts
@@ -135,11 +135,12 @@ async function save(options: SaveDialogOptions = {}): Promise<string> {
  *
  * @return {Promise<void>} A promise indicating the success or failure of the operation.
  */
-async function message(message: string): Promise<void> {
+async function message(message: string, title?: string): Promise<void> {
   return invokeTauriCommand({
     __tauriModule: 'Dialog',
     message: {
       cmd: 'messageDialog',
+      title,
       message
     }
   })