convert jest tests to child_process run script (#2308)

* convert jest tests to child_process run script

* remove vuecli (it freezes), add angular

* run cargo build in correct dir

* add in asserts on fs

* normalize assert for node14

* fix installing empty dependencies

* add messages to asserts

* use test dir to check if running local cli

* try running in parallel

* run in parallel and log output serially

* avoid parallel, skip yarn for now

* add change file

* disable running with npm6 due to vite fail

Co-authored-by: amrbashir <48618675+amrbashir@users.noreply.github.com>

Author: jbolda

.changes/cta-test-script.md

@@ -0,0 +1,6 @@
+---
+"create-tauri-app": patch
+"cli.js": patch
+---
+
+Adjust check for `dev` mode and switch CTA test to a script runner. The script gives us more control and better output into any failures.

.github/workflows/test-cta.yml

@@ -3,6 +3,9 @@
 # SPDX-License-Identifier: MIT
 
 name: test create-tauri-app
+env:
+  RUST_BACKTRACE: 1
+  TAURI_RECIPE: 'vanillajs,cra,vite,ngcli'
 
 on:
   workflow_dispatch:
@@ -13,20 +16,16 @@ on:
     paths:
       - "tooling/create-tauri-app/**"
 
-env:
-  RUST_BACKTRACE: 1
-
 jobs:
   create-recipe-with-npm:
-    name: "node@${{ matrix.node }} + npm@${{ matrix.manager }}: ${{ matrix.recipe }}"
+    name: "node@${{ matrix.node }} + npm@${{ matrix.manager }}"
     runs-on: ${{ github.event.inputs.platform || 'ubuntu' }}-latest
 
     strategy:
       fail-fast: false
       matrix:
         node: ["14", "16"]
-        manager: ["6", "7"]
-        recipe: ["vanillajs", "cra", "vite", "ngcli", "svelte", "dominator"]
+        manager: ["7"]
         exclude:
           - node: "16"
             manager: "6"
@@ -62,40 +61,37 @@ jobs:
       - run: yarn test
         working-directory: tooling/create-tauri-app
         env:
-          TAURI_RECIPE: ${{ matrix.recipe }}
           TAURI_RUN_MANAGER: "npm"
 
-  create-recipe-with-yarn:
-    name: "node@${{ matrix.node }} + yarn@1: ${{ matrix.recipe }}"
-    runs-on: ${{ github.event.inputs.platform || 'ubuntu' }}-latest
+  # create-recipe-with-yarn:
+  #   name: "node@${{ matrix.node }} + yarn@1"
+  #   runs-on: ${{ github.event.inputs.platform || 'ubuntu' }}-latest
 
-    strategy:
-      fail-fast: false
-      matrix:
-        node: ["14", "16"]
-        recipe: ["vanillajs", "cra", "vite", "ngcli", "svelte"]
+  #   strategy:
+  #     fail-fast: false
+  #     matrix:
+  #       node: ["14", "16"]
 
-    steps:
-      - uses: actions/checkout@v2
-      - name: install stable
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-      - uses: volta-cli/action@v1
-        with:
-          node-version: ${{ matrix.node }}
-          yarn-version: 1.22.5
-      - name: install webkit2gtk
-        if: (github.event.inputs.platform || 'ubuntu') == 'ubuntu'
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y libgtk-3-dev libgtksourceview-3.0-dev webkit2gtk-4.0 libappindicator3-dev
-      - run: yarn
-        working-directory: tooling/create-tauri-app
-      - run: yarn build
-        working-directory: tooling/create-tauri-app
-      - run: yarn test
-        working-directory: tooling/create-tauri-app
-        env:
-          TAURI_RECIPE: ${{ matrix.recipe }}
-          TAURI_RUN_MANAGER: "yarn"
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #     - name: install stable
+  #       uses: actions-rs/toolchain@v1
+  #       with:
+  #         toolchain: stable
+  #     - uses: volta-cli/action@v1
+  #       with:
+  #         node-version: ${{ matrix.node }}
+  #         yarn-version: 1.22.5
+  #     - name: install webkit2gtk
+  #       if: (github.event.inputs.platform || 'ubuntu') == 'ubuntu'
+  #       run: |
+  #         sudo apt-get update
+  #         sudo apt-get install -y libgtk-3-dev libgtksourceview-3.0-dev webkit2gtk-4.0 libappindicator3-dev
+  #     - run: yarn
+  #       working-directory: tooling/create-tauri-app
+  #     - run: yarn build
+  #       working-directory: tooling/create-tauri-app
+  #     - run: yarn test
+  #       working-directory: tooling/create-tauri-app
+  #       env:
+  #         TAURI_RUN_MANAGER: "yarn"

tooling/cli.js/src/helpers/rust-cli.ts

@@ -57,8 +57,8 @@ export async function runOnRustCli(
       onClose
     )
   } else {
-    if (existsSync(resolve(targetPath, '../bundler'))) {
-      // running local CLI
+    if (existsSync(resolve(targetPath, 'test'))) {
+      // running local CLI since test directory exists
       const cliPath = resolve(targetPath, '../cli.rs')
       spawnSync('cargo', ['build', '--release'], cliPath)
       const localCliPath = resolve(

tooling/create-tauri-app/package.json

@@ -29,7 +29,7 @@
     "lint:lockfile": "lockfile-lint --path yarn.lock --type yarn --validate-https --allowed-hosts npm yarn",
     "format": "prettier --write --end-of-line=auto \"./**/*.{cjs,js,jsx,ts,tsx,html,css,json}\" --ignore-path .gitignore",
     "format:check": "prettier --check --end-of-line=auto \"./**/*.{cjs,js,jsx,ts,tsx,html,css,json}\" --ignore-path .gitignore",
-    "test": "jest --runInBand"
+    "test": "node ./test/spawn.test.mjs"
   },
   "dependencies": {
     "chalk": "4.1.1",
@@ -39,16 +39,17 @@
     "scaffe": "1.1.0"
   },
   "devDependencies": {
+    "@effection/process": "2.0.0-beta.8",
     "@rollup/plugin-commonjs": "19.0.0",
     "@rollup/plugin-node-resolve": "13.0.0",
     "@rollup/plugin-typescript": "8.2.1",
     "@types/cross-spawn": "6.0.2",
     "@types/inquirer": "7.3.1",
-    "@types/jest": "26.0.23",
     "@types/minimist": "1.2.1",
     "@types/semver": "7.3.6",
     "@typescript-eslint/eslint-plugin": "4.25.0",
     "@typescript-eslint/parser": "4.25.0",
+    "effection": "2.0.0-beta.8",
     "eslint": "7.27.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-config-standard-with-typescript": "20.0.0",
@@ -57,11 +58,9 @@
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-promise": "5.1.0",
     "eslint-plugin-security": "1.4.0",
-    "fixturez": "1.1.0",
-    "jest": "27.0.3",
     "prettier": "2.3.0",
     "rollup": "2.50.4",
-    "ts-jest": "27.0.1",
+    "temp-dir": "^2.0.0",
     "tslib": "2.2.0",
     "typescript": "4.3.2"
   }

tooling/create-tauri-app/src/index.ts

@@ -368,7 +368,7 @@ const runInit = async (argv: Argv): Promise<void> => {
     logStep(`Updating ${reset(yellow('"package.json"'))}`)
     updatePackageJson(appDirectory, appName)
 
-    logStep(`Running: ${reset(yellow('tauri init'))}`)
+    logStep(`Running ${reset(yellow('"tauri init"'))}`)
     const binary = !argv.b ? packageManager : resolve(appDirectory, argv.b)
     // pnpm is equivalent to yarn and can run srcipts without using "run" but due to this bug https://github.com/pnpm/pnpm/issues/2764
     // we need to pass "--" to pnpm or arguments won't be parsed correctly so for this command only we are gonna treat pnpm as npm equivalent/