fix(core): Command::output suspend while wait for response (#8539)

* fix: Command::output suspend while wait for response * add change file --------- Co-authored-by: Lucas Nogueira <lucas@tauri.studio> Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
tauri-apps · Feb 1, 2024 · cc3d8e7 · cc3d8e7
1 parent 8ce51ce
commit cc3d8e7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.changes/fix-command-spawn-deadlock.md b/.changes/fix-command-spawn-deadlock.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch:bug
+---
+
+Fixes a deadlock when reading a stdout or stderr line returns an error.
diff --git a/core/tauri/src/api/process/command.rs b/core/tauri/src/api/process/command.rs
@@ -420,6 +420,7 @@ fn spawn_pipe_reader<F: Fn(String) -> CommandEvent + Send + Copy + 'static>(
         Err(e) => {
           let tx_ = tx.clone();
           let _ = block_on_task(async move { tx_.send(CommandEvent::Error(e.to_string())).await });
+          break;
         }
       }
     }
-Original file line number
+Diff line change
@@ Expand Up @@
             Err(e) => {
               let tx_ = tx.clone();
               let _ = block_on_task(async move { tx_.send(CommandEvent::Error(e.to_string())).await });
+              break;
             }
           }
         }
@@ Expand Down @@